fix(*): fix code to comply with SonarQube fix

teebow1e · Apr 18, 2024 · 0293862 · 0293862
1 parent b956277
commit 0293862
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 13 deletions.
diff --git a/src/main/java/loganalyzer/LogParser.java b/src/main/java/loganalyzer/LogParser.java
@@ -6,14 +6,17 @@
 import java.nio.file.Paths;
 import java.util.List;
 import java.util.regex.*;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 public class LogParser {
     private static final Pattern ipAddrPattern = Pattern.compile("(\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3})");
     private static final Pattern timestampPattern = Pattern.compile("\\[(\\d{2}/[A-Za-z]{3}/\\d{4}:\\d{2}:\\d{2}:\\d{2} [+\\-]\\d{4})]");
     private static final Pattern userAgentPattern = Pattern.compile("\"([^\"]*)\"[^\"]*$");
     private static final Pattern allInOnePattern = Pattern.compile("\"(GET|HEAD|POST|PUT|DELETE|CONNECT|OPTIONS|TRACE|PATCH) \\/[a-zA-Z0-9.\\-_~!$&'()*+,;=:@]+ (HTTP|HTTPS)\\/\\d+(\\.\\d+)*\" \\d{3}(\\.\\d+)? \\d+");
     public static void main(String[] args) {
-        String logFilePath = System.getProperty("user.dir") + "/logs/apache_nginx/access_log_10000.log";
+        Logger logger = Logger.getLogger(LogParser.class.getName());
+        String logFilePath = System.getProperty("user.dir") + "/logs/apache_nginx/access_log_50000.log";
         Path logPath = Paths.get(logFilePath);
 
         try {
@@ -35,15 +38,15 @@ public static void main(String[] args) {
                     }
                     System.out.println("------------------------------------------------");
                     lineCount++;
-                    if (lineCount >= 10000) {
+                    if (lineCount >= 50000) {
                         break;
                     }
                 }
             } else {
-                System.out.println("Log file does not exist: " + logPath);
+                logger.log(Level.SEVERE, "Log file not found at location " + logFilePath);
             }
         } catch (IOException e) {
-            System.out.println("Error reading log file: " + e.getMessage());
+            logger.log(Level.SEVERE, "Error reading log file: " + e.getMessage());
         }
     }
 

diff --git a/src/main/java/ui/Controller.java b/src/main/java/ui/Controller.java
@@ -12,19 +12,23 @@
 
 import java.io.File;
 import java.util.List;
+import java.util.logging.Logger;
+import java.util.logging.Level;
 
 public class Controller {
     private Stage stage;
-    public List<User> userLists;
+    private List<User> userLists;
+    // Not sure if declare logger here is correct
+    private Logger logger;
 
     public void init(Stage stage) {
+        Logger logger = new Logger.getLogger(Controller.class.getName());
         String dbFilePath = System.getProperty("user.dir") + "\\credentials\\cred.txt";
         File dbFile = new File(dbFilePath);
         if (dbFile.exists()) {
-            System.out.println("exists: " + dbFile.getAbsolutePath());
             userLists = UserManagement.readUserFile(dbFilePath);
         } else {
-            System.out.println("not exists: " + dbFile.getAbsolutePath());
+            logger.log(Level.SEVERE, "DB file not exists: " + dbFile.getAbsolutePath());
         }
         this.stage = stage;
     }
@@ -40,7 +44,7 @@ public void init(Stage stage) {
 
     @FXML
     private void onEnter(ActionEvent ae) throws Exception {
-        System.out.println("Key Enter clicked");
+        logger.log(Level.INFO, "Enter key pressed");
         handleLoginAccount(null);
     }
     @FXML
@@ -77,11 +81,11 @@ private void handleLoginAccount(MouseEvent event) throws Exception {
         System.out.println("Password: " + password);
         boolean authenticated = UserManagement.authenticateUser(userLists, username, password);
         if (authenticated) {
-            System.out.println("Login successful");
+            logger.log(Level.INFO, "Login successful");
             WebLogManager webLogManager = new WebLogManager();
             webLogManager.start(stage);
         } else {
-            System.out.println("Login failed");
+            logger.log(Level.INFO, "Login failed");
             JOptionPane.showMessageDialog(null, "Nhap sai password roi cu!");
         }
     }

diff --git a/src/main/java/ui/SidebarController.java b/src/main/java/ui/SidebarController.java
@@ -4,10 +4,8 @@
 import javafx.scene.Node;
 import javafx.scene.input.MouseEvent;
 import javafx.stage.Stage;
-import javafx.scene.control.*;
 
 public class SidebarController {
-
     private Stage stage;
 
     public void init(Stage stage) {

diff --git a/src/main/java/usermanagement/UserManagement.java b/src/main/java/usermanagement/UserManagement.java
@@ -5,8 +5,14 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 public class UserManagement {
+    private static final Logger logger = Logger.getLogger(UserManagement.class.getName());
+    private UserManagement() {
+        throw new IllegalStateException("Utility class");
+    }
     public static List<User> readUserFile(String fileName) {
         List<User> userList = new ArrayList<>();
         try (BufferedReader reader = new BufferedReader(new FileReader(fileName))) {
@@ -21,7 +27,7 @@ public static List<User> readUserFile(String fileName) {
                 }
             }
         } catch (IOException e) {
-            System.out.println("Error reading file: " + e.getMessage());
+            logger.log(Level.SEVERE, "An error occurred while reading the user file", e);
         }
         return userList;
     }