Skip to content
This repository has been archived by the owner on Nov 27, 2020. It is now read-only.

First take on supporting touch events #135

Closed
wants to merge 3 commits into from

Conversation

carhartl
Copy link
Contributor

For our touch platform web app we needed true touch events (we're not using click for interactions). Here's the first part.

I'd like to add some more methods, like double_tap and swipe.

In an acceptance test you simply write:

find('.tap-me').single_tap

@jonleighton
Copy link
Contributor

Thanks for the PR. As I first step, I think a discussion about the API for this ought to happen at the Capybara level. I don't know if anyone has proposed this to Capybara directly yet, but I want to be cautious about adding non-standard methods that could harm interoperability with other drivers.

So I think the first step is to agree on an API with the Capybara maintainers, then implement the API in Poltergeist.

Would you be up for finding/starting a Capybara ticket for this issue and adding your comments? Thanks

@jonleighton
Copy link
Contributor

I think this is better as an issue for now as I am not ready to merge the code yet. So I have created issue #141 where we can continue the discussion until we're ready to merge code. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants