[WHD-295] Feat: club payment statistics #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjunhub
reviewed
Dec 7, 2024
| @@ -40,4 +41,10 @@ public ListWrapperResponse<AdminItemHistoryResponse> getItemHistory(@PathVariabl | |||
| @RequestParam(required = false) LocalDate assignedTerm) { | |||
| return ListWrapperResponse.of(adminClubService.getItemHistory(clubId, assignedTerm)); | |||
| } | |||
|
|
|||
| @GetMapping("/{clubId}/clubPayments") | |||
There was a problem hiding this comment.
club-payments로 변경해보는건 어떨까요?
현재까지의 api 명세 방식이랑은 조금 다른 형태인 것 같아 여쭤봅니다!
There was a problem hiding this comment.
https://restfulapi.net/resource-naming/
이 사이트 참고해서 바꾸는 것도 좋은 생각인거 같습니다.
| @Test | ||
| @DisplayName("동아리 별 동아리 결제 내역 확인") | ||
| void getClubPayment() { | ||
| // When |
There was a problem hiding this comment.
요거 LocalDate.now() 사용해서 작성하게 되면, 내년 3월 이후부터 터지는 테스트가 될 것 같습니다!
명시적으로 LocalDate.of( )를 통해서 테스트에 해당하는 날짜를 지정해보는게 좋을 것 같습니다.
There was a problem hiding this comment.
given과 when에 둘다 LocalDate.now() 사용해서 테스트가 터지진 않지만 명시적으로 LocalDate.of( )를 사용하면 뚜렷하게 원하는 날짜를 테스트 할 수 있을 거 같습니다.
Test Coverage Report
|
Test Coverage Report
|
jjunhub
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 설명
작성 상세 내용
관련 지라 티켓 번호
WHD-295
참고 자료