[WHD-255] Feat: Club Group API #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
프론트 분들을 배려해서 미리 올려두셨군요 확인하였습니다. |
jjunhub
force-pushed
the
WHD-255_feat-club_group_api
branch
from
3b8594e to
b5b2f0c
Compare
- 그룹별로 고유한 Redis 락을 생성하여 동시에 다수의 쓰레드가 접근하는 상황 방지 - 기존 @transactional self-invocation 문제를 별도 서비스로 분리하여 해결 - 동시성 제어 테스트를 통해 예상된 그룹 멤버 수가 정확히 유지되는지 확인
jjunhub
changed the title
jjunhub
force-pushed
the
WHD-255_feat-club_group_api
branch
3 times, most recently
from
527ff78 to
f55e4a7
Compare
jjunhub
force-pushed
the
WHD-255_feat-club_group_api
branch
from
f55e4a7 to
d9c0268
Compare
Test Coverage Report
|
juy4844
reviewed
Dec 2, 2024
| import org.springframework.test.context.junit.jupiter.SpringExtension; | ||
| import woohakdong.server.WoohakdongServerApplication; | ||
|
|
||
| @Target(ElementType.TYPE) |
| group.changeAvailability(); | ||
| } | ||
|
|
||
| public void joinGroup(Long groupId, LocalDate date) { |
There was a problem hiding this comment.
redis로 lock쓰는거 처음 봅니다. 최고에요 @transaction 안붙이는 디테일 너무 훌륭합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 설명
작성 상세 내용
관련 지라 티켓 번호
WHD-255
참고 자료
0.05초동안 10개의 쓰레드가 7명 정원인 그룹 참여 시도 테스트 결과
