Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WHD-239] Feat: Search clubMembers with keyword #46

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[WHD-239] Feat: Search clubMembers with keyword #46

merged 1 commit into from
Nov 15, 2024

Conversation

jjunhub
Copy link
Member

@jjunhub jjunhub commented Nov 14, 2024 •
edited by jira bot
Loading

기능 설명

검색어로 분기별 동아리 회원 조회 가능

작성 상세 내용

  • 멤버 이름이 존재하지 않는다면, 해당 분기의 모든 멤버를 조회한다.
  • QueryParameter의 유무에 따라 호출할 메소드를 결정할 책임을 Repository 단으로 전달

관련 지라 티켓 번호

WHD-239

참고 자료

@jjunhub jjunhub requested a review from juy4844 November 14, 2024 15:43
@github-actions GitHub Actions
Copy link

Test Coverage Report

Overall Project 63.45% -0.26% 🍏
Files changed 82.28% 🍏

File Coverage
NotificationService.java 95.76% 🍏
ClubMemberRepositoryImpl.java 88.64% 🍏
ClubMemberService.java 85.06% -3.9% 🍏
ClubMemberController.java 0% -30.77% ❌

@juy4844
Copy link
Contributor

juy4844 commented Nov 15, 2024

확인했습니다.

@jjunhub jjunhub merged commit 69564cf into develop Nov 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juy4844 juy4844 juy4844 left review comments

Assignees

@juy4844 juy4844

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjunhub @juy4844