[WHD-94] Feat : Add member info api #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- member 추가 정보 test 완료
- getMemberInfo test 완료
jjunhub
reviewed
Oct 11, 2024
Comment on lines
+26
to
+29
| @ExceptionHandler(Exception.class) | ||
| public void handleValidationExceptions(Exception ex) { | ||
| log.error("Exception : {}", ex.getMessage()); | ||
| } |
There was a problem hiding this comment.
혹시 이거 이렇게 하면은 클라이언트가 어떻게 받게 되나요?
그냥 에러 로그만 서버쪽에 남는걸까요?
|
위에 Exception에 대해서 클라이언트 쪽에 에러 발생했다고 간략하게 응답 주는 코드만 추가되면 좋을 것 같습니다! |
jjunhub
added a commit
that referenced
this pull request
Oct 20, 2024
* [WHD-24] CI/CD: Setup CI/CD pipeline for dev server deployment (#1) * [WHD-24] CI/CD: Add Dockerfile - 멀티 스테이지를 이용하여 빌드와 이미지 생성을 진행하였다. - 스테이지 1: 소스 코드 테스트 및 빌드 진행 - 스테이지 2: 빌드 결과물을 image로 생성 * [WHD-24] CI/CD: Add GitHub Action Script * [WHD-24] CI/CD: Fix GitHub Action Script - 빌드한 docker image를 바로 AWS ECR로 push 진행 - github action 환경에서 여러 이미지를 갖고 있을 수 없기 때문 * [WHD-24] CI/CD: Fix typo * [WHD-24] CI/CD: Improve speed with not use buildx * [WHD-24] CI/CD: Make docker build process separately - buildx가 시간이 너무 오래 걸리는 문제가 존재하였다. - 이를 docker 기본 multi-platform 빌드 옵션으로 2번 빌드하여 push하는 쪽으로 변경하였다. * [WHD-24] CI/CD: Make docker image for multi platform * [WHD-24] CI/CD: Use dev- tag prefix for ECR life cycle policy * [WHD-24] CI/CD: Add ssh action for deploy at dev EC2 * [WHD-24] CI/CD: Fix typo * [WHD-24] CI/CD: Fix build job make output * [WHD-24] CI/CD: Make .pem key decode * [WHD-24] CI/CD: Test github action * [WHD-24] CI/CD: Test github action * [WHD-24] CI/CD: Retry github Action * [WHD-24] CI/CD: Add ECR login command to pull image * [WHD-24] CI/CD: Add sudo command for docker-compose * [WHD-24] CI/CD: Use .env file for secret variables * [WHD-24] CI/CD: Use command to set secrets in docker-compose * [WHD-24] CI/CD: Fix typo * [WHD-24] CI/CD: Fix typo * [WHD-24] CI/CD: Use crossorigin annotation for test * [WHD-24] CI/CD: Add cleanup step for unused Docker images * [WHD-24] CI/CD: Change trigger not to use this branch * [WHD-27] Feat: Add AWS S3 dependencies * [WHD-111] Feat: Add global exception handler - 예외 처리 핸들러 추가 - CustomErrorInfo를 이용하여 에러 추가 가능 - Resolves WHD-111 * [WHD-80] Feat: Add jwt, security dependencies * [WHD-80] Feat: Add SecurityConfig * [WHD-80] Chore: rearranging code * [WHD-80] Chore: rearranging code2 * [WHD-24] CI/CD: Optimize GitHub Actions workflow with cache - 테스트 관련 job 분리 - 캐시를 이용하여 Gradle 빌드 속도를 높임 - skip deploy * [WHD-81] Feat: JWT를 이용한 인증, 로그아웃, 리프레쉬 토큰 발급 로직 개발 (#7) * [WHD-80] Feat: Add Member Entity and School Entity * [WHD-81] Feat: Create login logic - JWTUtil class 생성 - /auth/login/social api logic 작성 * [WHD-81] Refactor: refacor code - gender enum 형식으로 수정 - @requiredargsconstructor로 형식 바꿈 * [WHD-81] Feat: Add Jwt filter - jwt token을 인증하고 임시 세션을 부여한다. * [WHD-81] Feat: Add swagger * [WHD-81] Feat: school domain test * [WHD-81] Feat: Add refresh jwt tokens - /v1/auth/refresh 로 오면 access token과 refresh token을 재발급한다. - jwtutil에서 isExpired 함수 exception 안나도록 수정 * [WHD-81] Feat: Add logout * [WHD-81] Feat: Add Ajou data * [WHD-81] Fix: fix Test code - 초기 데이터 세팅과 test에서 데이터 세팅 충돌 에러 수정 * [WHD-81] Refactor: Partial correction received after pr * [WHD-81] Refactor: update code * [WHD-81] Fix: update CustomException * [WHD-18] Docs: Add Pull Requests template * [WHD-97] Feat : api for S3 Presigned Url (#8) * [WHD-97] Fix: Change AWS S3 dependencies * [WHD-97] Feat: Setup swagger - SpringDoc기반 Swagger UI 세팅 - SecurityFilter에서 Swagger 관련 endpoint들 제외 * [WHD-97] Feat: Implement S3 presigned URL generation * [WHD-97] Feat: Add endpoint for generating S3 presigned URLs - UtilControllerDocs 작성을 통한 Swagger 작성 - UtilController, UtilService 구현 * [WHD-97] Chore: Resolve conflicts during rebase * [develop] Fix: Add @RequestBody * [WHD-24] CI/CD: Change not to build arm64 image - production 1차 출시 전까지 리소스 비용 감소를 위해서 - PR에 특정 키워드 작성 시, develop 서버 배포 미진행 * [WHD-98] Feat: Make club entity * [WHD-98] Feat: Make Gathering entity * [WHD-94] Feat : Add member info api (#10) skip deploy * [develop] Fix: Add @RequestBody * [WHD-81] Fix: set cors config * [WHD-87] Feat: Make ClubMember entity - #in-progress * [WHD-99] Chore: Add column of ClubMember entity - clubGeneration 추가 - WHD-99 #in-progress 로 변경 * [WHD-99] Feat: Make swagger for club api * [WHD-99] Feat: Make club create api * [WHD-99] Feat: Implement mock bank service * [WHD-99] Feat: Make ClubAccount entity * [WHD-99] Feat: Create club account register api - Club, ClubAccount 연관관계 추가 - 동아리 생성 시, 해당 인원을 동아리 회장으로 임명하는 로직 구현 - 계좌 등록 시, 해당 동아리의 회장만이 계좌 등록할 수 있도록 권한 제어 - 테스트 코드 작성 * [WHD-99] Feat: Change club name validate paramter - dto로 request 받도록 수정 - 테스트 코드 작성 - docs 부분에 미구현 코드 진행 중으로 표시 * [WHD-99] Feat: Add clubGeneration column to Club entity * [WHD-99] Fix: Add RequestBody Annotation * [WHD-127] Fix: Injects AWS config with github secret * [WHD-100] Feat: Implement API to get club information * [WHD-100] Feat: Make join type gathering get api * [WHD-118] Fix: Resolve merge conflict * [WHD-118] Fix: Remove ClubMemberRepository Optional - 오타수정 - @Valid 추가 - Controller 단 ListWrapperResponse 추가 * [WHD-123] Feat: Setup portone config * [WHD-123] CI/CD: Inject portone secrets with GitHub Action * [WHD 124] Feat: Add transfer to club (#17) * [WHD-124] Feat: Add account Bank Code logic * [WHD-124] Feat: Add Transfer logic * [WHD-124] Feat: Add ClubAccountHistory domain * [WHD-124] Feat: Add Admin domain * [WHD-124] Feat: Add admin account histroy save logic * [WHD-124] Feat: Add transfer test code * [WHD-124] Fix: Add Bank Code ClubAccountRepositoryTest * [WHD-124] Chore: rename account history amt -> amount * [WHD-110] Refactor: Change entity name of gathering to group. * [WHD-110] Feat: Implement API for club info * [WHD-110] Feat: Add Order, Payment entity * [WHD-110] Feat: Implement payment logic with portone * [WHD-110] Fix: Change NotBlank to NotNull * [WHD-110] Fix: Change cors settings for web * [WHD-110] Chore: Change deploy setting for test * [WHD-110] Feat: Implement API for find club with clugEnglishName * [WHD-110] Feat: Implement API for find club with clugEnglishName * [WHD-110] Feat: Implement API for portone Webhook * [WHD-122] Chore: Change exception response logic for client * [WHD-122] Fix: Add RequestParam for api * [WHD-122] Chore: Add test data * [WHD-122] Fix: Change relationship of Order and Group * [Develop] Feat: Add clubHistory entity * [Develop] Feat: Add get club history usage date * [WHD-170] Fix: Change origin name - http에서 https로 변경 --------- Co-authored-by: juy4844 <[email protected]> Co-authored-by: juy4844 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기능 설명
member info api 개발 및 테스트 코드 작성
작성 상세 내용
관련 지라 티켓 번호
WHD-94