Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#94 my account #97

Merged
merged 17 commits into from
Jan 17, 2024
Merged

Feature/#94 my account #97

merged 17 commits into from
Jan 17, 2024

Conversation

BEEEAM-J
Copy link
Member

@BEEEAM-J BEEEAM-J commented Jan 15, 2024 •
edited
Loading

📌 PR 요약

🌱 작업한 내용

  • 내 계정관리, 비밀번호 변경, 회원 탈퇴 기능 구현했습니다.

🌱 PR 포인트

  • 비밀번호 변경 화면에서 버튼이 활성화 되게 하는 로직이 효율적이지 못한 거 같다는 생각이 드는데 이 부분 확인 부탁드립니다. (상태 관리가 어렵네유...)
  • 비밀번호 변경, 회원 탈퇴 api 연동은 기존의 UseCase를 사용하여 구현했는데 "파라미터가 올바르지 못합니다" 라는 400 에러가 발생해서 실제로 동작하는지는 확인하지 못했습니다.

🌱 PR 포인트2

  • 플로우 예외처리를 catch 함수로 수정하였습니다.
  • MyAccountScreen HorizontalDivider 색상이 디자인과 다르던 문제 수정했습니다.

📸 스크린샷

default.mp4

📮 관련 이슈

@BEEEAM-J BEEEAM-J self-assigned this Jan 15, 2024
jinukeu
jinukeu requested changes Jan 16, 2024
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 반영 끝나고 re-request 해주시면 UseCase 부분은 제가 한번 봐볼게요!

feature/myinfo/src/main/java/com/suwiki/feature/myinfo/myaccount/MyAccountViewModel.kt Outdated Show resolved Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/quit/QuitViewModel.kt Outdated Show resolved Hide resolved
feature/myinfo/src/main/java/com/suwiki/feature/myinfo/resetpassword/ResetPasswordContract.kt Show resolved Hide resolved
@BEEEAM-J BEEEAM-J requested a review from jinukeu January 16, 2024 19:19
jinukeu
jinukeu approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@jinukeu jinukeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다! 확인 후 Merge 부탁드려요~

@BEEEAM-J BEEEAM-J merged commit 363660f into develop Jan 17, 2024
1 check passed
@jinukeu jinukeu deleted the feature/#94-my-account branch January 24, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinukeu jinukeu jinukeu approved these changes

Assignees

@BEEEAM-J BEEEAM-J

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 계정관리
2 participants
@BEEEAM-J @jinukeu