Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: consistency around how we refer to GlobalSymbolRegistry stuff #3525

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Editorial: consistency around how we refer to GlobalSymbolRegistry stuff #3525

merged 1 commit into from
Jan 23, 2025
+5 −5

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Jan 15, 2025

  • always refer to "the GlobalSymbolRegistry List" instead of sometimes just saying "GlobalSymbolRegistry"
  • when creating a GlobalSymbolRegistry Record, do so explicitly
  • dfn "GlobalSymbolRegistry List"

@bakkot bakkot force-pushed the symbol-for-record branch from bcdd49b to da5377d Compare January 15, 2025 23:07
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Jan 22, 2025
@ljharb ljharb force-pushed the symbol-for-record branch from fc178ee to 810a33f Compare January 23, 2025 06:23
@ljharb ljharb merged commit 810a33f into main Jan 23, 2025
9 checks passed
@ljharb ljharb deleted the symbol-for-record branch January 23, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

Assignees
No one assigned
Labels
editorial change ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakkot @syg @michaelficarra @ljharb