Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove unused %AggregateErrorPrototype% intrinsic #2124

Closed
wants to merge 1 commit into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Aug 3, 2020

This is non-normative since it is not a function, and nothing uses it in this or any other spec. It was mistakenly added in #2040.

@ljharb ljharb requested review from syg, michaelficarra, bakkot and a team August 3, 2020 20:40
@ljharb
Copy link
Member Author

ljharb commented Aug 3, 2020

Just realized why none of these aren't auto-linking - https://tc39.es/ecma262/#sec-nativeerror used to dynamically refer to them, but now it uses the dotted intrinsic form.

We could save this one for #2056, and leave it now for consistency, or merge this now. Up to yall.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Aug 4, 2020
@michaelficarra
Copy link
Member

michaelficarra commented Aug 5, 2020

I say just throw it in to #2056. In the editor call, I would like to talk about the poor usability of our dynamic definitions of errors and typed arrays.

edit: Result of this discussion: #2135

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Aug 6, 2020

I suggested this in #2040 (comment), but it was rejected by @chicoxyzzy because of tc39/proposal-promise-any#37 (comment).

@ljharb
Copy link
Member Author

ljharb commented Aug 6, 2020

Indeed :-) I did some grepping and couldn't find uses of this one, so I made the PR; but then I realized it was the NativeError magic.

@caridy
Copy link
Contributor

caridy commented Aug 6, 2020

I'm getting confused by the different comments here. My assumption is that you cannot remove this since it is an undeniable intrinsic. Some objects will be created with __proto__ set to this intrinsic object.

@ljharb
Copy link
Member Author

ljharb commented Aug 6, 2020

@caridy i'm not sure why that makes a difference? %AggregateError.prototype% will always refer to this object; the non-dotted form is a legacy way of referencing it. An intrinsic no longer needs to be "well-known" to be accessible via the % syntax.

@caridy
Copy link
Contributor

caridy commented Aug 7, 2020

@ljharb thanks for the clarification. It makes perfect sense now!

@ljharb ljharb removed the editor call to be discussed in the next editor call label Aug 12, 2020
This is non-normative since it is not a function, and nothing uses it in
this or any other spec. It was mistakenly added in tc39#2040.
@ljharb ljharb force-pushed the aggregate_error_proto_intrinsic branch from 23b6f28 to dede2eb Compare September 2, 2020 22:09
@ljharb ljharb closed this in #2056 Sep 2, 2020
@ljharb ljharb deleted the aggregate_error_proto_intrinsic branch September 2, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants