Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update toml to 0.8 #13

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Conversation

hjmallon
Copy link

@hjmallon hjmallon commented Dec 1, 2023

repo builds both toml 0.7 and 0.8, this means it only needs 0.8

@FabianLars
Copy link
Member

Thanks for contributing! :)

This is actually intentional because 0.8 is incompatible with tauri's msrv and i didn't want to maintain 2 versions of winres (one for v1, one for v2). That said, there are only one or two issues we have to triage that may need changes in winres and then we can merge this. I will keep this PR open until then.

@hjmallon
Copy link
Author

hjmallon commented Dec 1, 2023

Oh right! embed-resource seems to pull toml 0.8 now (with 2.4) so does that still work? Or is cargo clever enough not to pull toml embed-resource 2.4?

@FabianLars
Copy link
Member

FabianLars commented Dec 1, 2023

If you run cargo update, or don't have a lockfile, it's unfortunetly not smart enough. But you can run cargo update -p rust-embed --precise 2.3.0 to downgrade it again.

If you wanna see something (not) fun: https://github.com/tauri-apps/tauri/blob/1.x/.github/workflows/test-core.yml#L87 (because committing the lockfile would be too easy...)

@thomaseizinger
Copy link

Could this be reconsidered now that Tauri v2 is released? tauri-winres is still being pulled in via tauri-build.

@FabianLars
Copy link
Member

oh lol, yes of course. i totally forgot about this.

@FabianLars FabianLars changed the title update toml to 0.8 chore(deps): update toml to 0.8 Jan 10, 2025
@FabianLars FabianLars merged commit fad716e into tauri-apps:main Jan 10, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants