-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.18.x] Remove ImGui in favor of online web service #55
Closed
andriihorpenko
wants to merge
10
commits into
tasgon:1.18
from
andriihorpenko:feature/imgui_to_online
Closed
[1.18.x] Remove ImGui in favor of online web service #55
andriihorpenko
wants to merge
10
commits into
tasgon:1.18
from
andriihorpenko:feature/imgui_to_online
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you so much for the contribution! I haven't had the time yet to do a review yet, but I'll do one today. |
Looking through it, I have a few thoughts:
Overall, I like most of the PR, but there's a few changes I want to make on the 1.19 branch before backporting, and quite honestly I'm not sure what to do regarding point 3. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR merges original
1.18-online
branch with additional commits from 1.19 branch.Effects
Notes
ru
localization as it was clearly generated by some sort of Google Translator. Not cool, not cool! If this gets through,ru
localization can be ported to 1.19 branch.