Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when try to check Results | 1.18.2 #53

Open
6e3noHToBui opened this issue May 19, 2023 · 4 comments
Open

Crash when try to check Results | 1.18.2 #53

6e3noHToBui opened this issue May 19, 2023 · 4 comments

Comments

@6e3noHToBui
Copy link

After profiling, try to seen all results and minecraft closing.
Crash log: bruh

@tasgon
Copy link
Owner

tasgon commented May 19, 2023

Sounds like a duplicate of #12. From my observations, the issue is fairly infrequent, so it should function when you open the game again. I fixed the issue for 1.19 but didn't backport it to 1.18 yet.

@6e3noHToBui
Copy link
Author

Okay, thanks, we'll be waiting it in 1.18

@andriihorpenko
Copy link
Contributor

I can backport a fix to 1.18 if you could mention commit hash with a potential fix.

@tasgon
Copy link
Owner

tasgon commented May 25, 2023

The fix was to completely scrap the in-game results window and replace it with the online service at https://o.tas.sh. Technically, the 1.18-online branch should already have most of the changes, but I didn't have enough time then to test and release a new version with the changes.

@andriihorpenko If you're interested in helping, I'd recommend pulling that branch and testing it out to see if it works, then comparing it with the current 1.19 codebase to see if anything else relevant would need to be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants