[FIX] web_widget_x2many_2d_matrix: support One2many field as value field #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[MIG] web_widget_x2_many_2d_matrix: Migration to 16.0 (WIP, columns) [MIG] web_widget_x2_many_2d_matrix: Migration to 16.0 (WIP, rows) [MIG] web_widget_x2_many_2d_matrix: Migration to 16.0 (WIP, add value component) Aggregated values [MIG] web_widget_x2many_2d_matrix: Fix commitChanges of matrix. [FIX] Fix commitChanges [FIX] setDirty [FIX] Aggregated values [IMP] readonly working [FIX] Update matrix on changing props [FIX] Remove old files [IMP] Run precommit stuff [FIX] Remove deprecated readme sections [MIG] Migrate show_row_totals and show_column_totals attributes [MIG] sticky headers Fixup Fixup Fixup
|
Hi, I tested with this PR it show sum column and row is not correct This version of OCA#2463 This PR version. I add show_row_totals="1" in field but it still not show sum row |
|
@tarteo thanks for checking! As I said, my PR is only a partly fix for the issue. I believe a validation on the “summability” of the aggregated column should be done in the frontend. Since you have a working setup, perhaps you can address the issue? |
tarteo
force-pushed
the
16-mig-matrix-widget
branch
3 times, most recently
from
b9d3f0e
to
feee650
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream migration PR you created here does not completely work and needs to be expanded. For instance, the use of Many2one fields as values is currently not supported. My PR applies some additional fixes in order to add support for that.