address cron job confusion and update dependencies #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #53 (thanks for bringing it to my attention @jnavarro86
There are a lot of details to this is #53, but the summary is that the cron library being used defaulted to a parser that used seconds (required) with day of week being optional. In newer versions of the library, the default parser still uses seconds, but includes better documentation and usability for making custom parse formats. I changed the parsing format to include optional seconds with required day-of-week, which is closer to the standard (differing only by inclusion of optional seconds).
This change should help alleviate any confusion.
* * * * *
now complies with standard cron (starting with minutes)* * * * * *
starts with seconds and includes day of weekBefore this change the behavior is actually:
* * * * *
starts with seconds and does not include a day of week* * * * * *
starts with seconds and includes day of weekThis is arguably a breaking change, or arguably just a bug fix. I'm going with the later given my own expectations of how it worked.
Along the way, I need to update one dependency, so I just updated a number. Credit to @jdharmon for doing the heavy lifting on dependency updates -- this should be compatible with the changes to #50
What's included:
What could "break"?
The case where things changes is when someone was using
* * * * *
. For anyone doing this, this PR will change that behavior to matching the standard cron format. If someone was intentionally relying on that being non-standard, then this might cause some minor pain in either the reaper running less frequently, or no longer being a valid cron format (which should error). I think this is reasonable to be considered as a fix rather than a breaking change.Paging @slushpupie for a review 😄