Add Option to Force Replies in Thread for Google Chat Bot #488
Conversation
vsychov
requested review from
delta592,
wass3rw3rk,
sjqnn and
JordanSussman
as code owners
vsychov
changed the title
Pull Request Test Coverage Report for Build 6826967060
💛 - Coveralls |
| @@ -95,6 +94,7 @@ func toMessage(m *pubsub.Message) (models.Message, error) { | |||
| if event.User != nil { | |||
| message.Vars["_user.name"] = event.User.DisplayName | |||
| message.Vars["_user.id"] = event.User.Name | |||
| message.Vars["_user.internal_id"] = event.User.Name | |||
There was a problem hiding this comment.
curious about this, since it's already available as _user.id?
There was a problem hiding this comment.
_user.id is overwritten in the following lines by the email, if it exists.
flottbot/remote/gchat/helper.go
Line 103 in 1f7c870
There was a problem hiding this comment.
Ah, thanks! I missed that, sorry. I wonder why we are not using _user.email for that other spot as we are using that for Slack. Seems a little cleaner.
There was a problem hiding this comment.
@justmiles friendly ping - was there are particular reason for overwriting _user.id with email? otherwise, i think populating _user.email would be more appropriate.
There was a problem hiding this comment.
@wass3r , I absolutely agree that _user.email looks much more logical and cleaner, I left it as is, adding a new field only in order not to break backward compatibility in existing user scripts. However, I am happy to rename the fields if you see no issues with backward compatibility.
There was a problem hiding this comment.
@vsychov i appreciate that you made the change in a thoughtful manner! i'll give it a day or so for chance of response here. otherwise, happy to merge this and might raise PR myself for making that breaking change and call it out in release notes.
There was a problem hiding this comment.
i'll go ahead and merge. thanks again.
Proposed change
This patch introduces a enhancement to the bot functionality with Google Chat. It has been observed that Google Chat has ceased to provide the
event.Space.Threadedvalue, leading to an issue where the bot could not determine whether a message was sent in a thread or directly to the group. As a result, the bot was defaulting to responding only in the group and never in a thread.To resolve this issue, a new global configuration option,
google_chat_force_reply_to_thread, has been added to the bot's settings. This boolean setting allows administrators to specify whether the bot should always reply within a thread if available or continue to respond in the group. The new setting ensures that the bot's replies are consistent with the desired conversation flow, enhancing the overall user interaction with the bot within Google Chat environments.Types of changes