Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS testing #273

Merged
merged 7 commits into from
Dec 29, 2022
Merged

Add macOS testing #273

merged 7 commits into from
Dec 29, 2022

Conversation

better0fdead
Copy link
Contributor

Added macOS test workflow.
Fixed tests for macOS.

  • Tests - not needed
  • Changelog - not needed
  • Documentation - not needed

Closes #254
Closes #170

@better0fdead better0fdead added the full-ci Enables full ci tests label Dec 5, 2022
@better0fdead better0fdead force-pushed the better0fdead/no-gh-macOS-tests branch 3 times, most recently from b24f3e5 to 90490c0 Compare December 6, 2022 13:48
@better0fdead better0fdead marked this pull request as draft December 6, 2022 14:23
@better0fdead better0fdead added full-ci Enables full ci tests and removed full-ci Enables full ci tests labels Dec 6, 2022
@better0fdead better0fdead added the full-ci Enables full ci tests label Dec 6, 2022
@better0fdead better0fdead force-pushed the better0fdead/no-gh-macOS-tests branch 3 times, most recently from ea934b1 to 305f078 Compare December 7, 2022 07:34
@better0fdead better0fdead removed the full-ci Enables full ci tests label Dec 19, 2022
@better0fdead better0fdead added the full-ci Enables full ci tests label Dec 19, 2022
@better0fdead better0fdead added full-ci Enables full ci tests and removed full-ci Enables full ci tests labels Dec 19, 2022
@better0fdead better0fdead added full-ci Enables full ci tests and removed full-ci Enables full ci tests labels Dec 19, 2022
@better0fdead better0fdead marked this pull request as ready for review December 19, 2022 13:53
@better0fdead better0fdead added full-ci Enables full ci tests and removed full-ci Enables full ci tests labels Dec 19, 2022
@better0fdead better0fdead added full-ci Enables full ci tests and removed full-ci Enables full ci tests labels Dec 20, 2022
@better0fdead better0fdead force-pushed the better0fdead/no-gh-macOS-tests branch 2 times, most recently from 3629609 to 6718993 Compare December 20, 2022 12:06
psergee
psergee requested changes Dec 27, 2022
View reviewed changes
.github/workflows/full-ci.yml Outdated Show resolved Hide resolved
cli/build/build_test.go Outdated Show resolved Hide resolved
cli/build/build_test.go Outdated Show resolved Hide resolved
cli/install_ee/install_ee_test.go Outdated
`1.10.10-52-g0df29b137-r419.tar.gz">tarantool-enterprise-bundle-1.10.10-` +
`52-g0df29b137-r419.tar.gz</a> 2021-08-18 ` +
arch, err := util.GetArch()
assert.Nil(err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suppose, it must be require. And there is a special function for errors: NoError. It is more readable. Don't use Nil to check if no error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use require instead of assert here. Suppose, the test should not continue if GetArch or GetOs fails.

cli/install_ee/install_ee_test.go Outdated Show resolved Hide resolved
cli/install_ee/install_ee_test.go Outdated Show resolved Hide resolved
cli/install_ee/install_ee_test.go Outdated Show resolved Hide resolved
cli/build/build_test.go Outdated Show resolved Hide resolved
@better0fdead
install: add openssl to macOS requirments
5b93d3a 
Added openssl to 'tt install' macOS requirments.

Part of #254
@better0fdead better0fdead force-pushed the better0fdead/no-gh-macOS-tests branch 3 times, most recently from aa2d2fa to 8d3f0a1 Compare December 29, 2022 09:28
psergee
psergee reviewed Dec 29, 2022
View reviewed changes
cli/build/build_test.go Show resolved Hide resolved
test/integration/pack/test_pack.py Outdated Show resolved Hide resolved
@better0fdead
tt: fix unit tests
61254aa 
Fixed unit tests.
Since /private/var and /var/ in macOS are symlinks, there is no real
difference between them and it should not cause error.
Added macOS support for TestGetVersions.

Follow up #254
Closes #170
@better0fdead
test: skip unsupported tests on macOS
3e44d00 
Added skip to unsupported tests on macOS.

Part of #254
@better0fdead
test: change tarantool install version
08572a5 
Changed version of tarantool for "tt install".

Part of #254
@better0fdead
test: add slow mark for pack test
e0d9e92 
Added slow mark for test_pack_deb_use_docker since it runs
./tt install tarantool= .
@better0fdead
CI: add macOS testing
1f3a945 
Added testing on macOS into workflow.

Closes #254
@vr009
pack: remove a redundant copying of binaries
eed6df6 
With this patch removed a redundant copying of binary files into
a temporary prepared directory that will be mapped to container.

Follow up #133
Follow up #254
@LeonidVas LeonidVas merged commit 7cac332 into master Dec 29, 2022
@LeonidVas LeonidVas deleted the better0fdead/no-gh-macOS-tests branch December 29, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psergee psergee psergee approved these changes

@0x501D 0x501D 0x501D approved these changes

@LeonidVas LeonidVas Awaiting requested review from LeonidVas

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests to macos workflow Integration tests fail on MacOS
5 participants
@better0fdead @0x501D @psergee @LeonidVas @vr009