ci: add luacheck linter #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themilchenko
requested review from
oleg-jukovec,
DifferentialOrange and
DerekBum
and removed request for
oleg-jukovec
themilchenko
force-pushed
the
themilchenko/gh-21-add-linter-in-ci
branch
2 times, most recently
from
f546a86
to
64b266f
Compare
oleg-jukovec
approved these changes
Nov 4, 2024
themilchenko
force-pushed
the
themilchenko/gh-21-add-linter-in-ci
branch
from
64b266f
to
6c34761
Compare
DifferentialOrange
approved these changes
Nov 5, 2024
themilchenko
force-pushed
the
themilchenko/gh-21-add-linter-in-ci
branch
from
6c34761
to
9cf0640
Compare
README.md
Outdated
Comment on lines
209
to
223
| After that you need to install dependencies (`tt` is required). | ||
| It's possible to install requirements only for running tests | ||
| or linter check. To install all of this, run: | ||
|
|
||
| ```shell | ||
| make deps | ||
| ``` | ||
|
|
||
| To install only tests requirements, run: | ||
|
|
||
| ```shell | ||
| make deps depname=test | ||
| ``` | ||
|
|
||
| To install tests with coverage requirements, run: |
There was a problem hiding this comment.
Suggested change
| After that you need to install dependencies (`tt` is required). | |
| It's possible to install requirements only for running tests | |
| or linter check. To install all of this, run: | |
| ```shell | |
| make deps | |
| ``` | |
| To install only tests requirements, run: | |
| ```shell | |
| make deps depname=test | |
| ``` | |
| To install tests with coverage requirements, run: | |
| After that you need to install dependencies (`tt` is required). | |
| To do it, run: | |
| ```shell | |
| make deps | |
| ``` | |
| It's possible to install requirements only for running tests | |
| or linter check. To install only tests requirements, run: | |
| ```shell | |
| make deps depname=test | |
| ``` | |
| To install tests with coverage requirements, run: |
Since it will be more convenient to see CI jobs making its own work, the installation of rocks was rewriten to install rocks only for one task.
There was a linter check in test in `testing` workflow, but not in a separate job. After the patch a linter check is available in a separate job and the previous step from `testing` workflow was deleted. Closes #21
themilchenko
force-pushed
the
themilchenko/gh-21-add-linter-in-ci
branch
from
9cf0640
to
6d6526b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a linter check in test in
testingworkflow, but not in a separate job.After the patch a linter check is available in a separate job and the previous step from
testingworkflow was deleted.Closes #21