-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: migrate to httpd role server #18
api: migrate to httpd role server #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests are red.
a5b80a0
to
71321be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix the comments below. We could also to improve the code and to use router:delete instead of the call:
metrics-export-role/roles/metrics-export.lua
Lines 27 to 38 in a5b80a0
local function delete_route(httpd, name) | |
local route = assert(httpd.iroutes[name]) | |
httpd.iroutes[name] = nil | |
table.remove(httpd.routes, route) | |
-- Update httpd.iroutes numeration. | |
for n, r in ipairs(httpd.routes) do | |
if r.name then | |
httpd.iroutes[r.name] = n | |
end | |
end | |
end |
a43e014
to
ae8434a
Compare
Replaced on router:delete instead of the call. |
ae8434a
to
680b4e5
Compare
680b4e5
to
4689696
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
26923ee
to
4d8ef4c
Compare
4d8ef4c
to
3d85ea3
Compare
3d85ea3
to
722abf5
Compare
Since the `httpd` role was released this role has been needed support for this feature. After the patch metrics-export-role supports an `httpd` role. It is possible to determine a list of servers that role will reuse in the following configuration. Closes #15
722abf5
to
d439bcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ready to merge.
Since the
httpd
role was released this role need to support this feature.After the patch metrics-export-role supports an
httpd
role. It is possible to determine a list of servers that role will reuse in the following configuration.Closes #15