server: fix assertion error serialization in exec() #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e6a2093 ("Add error handling at the server instance") broke assertion failure reporting in `server:exec()` in case verbose error serialization is enabled in Tarantool (`box_error_serialize_verbose` compatibility option is set to `new`). The problem is with the verbose error serialization, a raw string raised with `error()` is converted to an error object when marshalled through IPROTO while the `server:exec()` code expects it to remain a string because it encodes the original error in JSON. As a result, we get a mangled error like ``` {"status":"fail","class":"LuatestError","message":"...some_test.lua:42: expected: a value evaluating to true, actual: false"} {"code":32,"type":"LuajitError","trace":[{"file":"./src/lua/utils.c","line":687}]} ``` instead of ``` ...some_test.lua:42: expected: a value evaluating to true, actual: false ``` To fix this issue, we revert the JSON encoding hack introduced by the aforementioned commit. In order not to reintroduce issue tarantool#242 fixed by that commit, we simply rollback the active transaction (if any) in case the executed function failed. Closes tarantool#376
locker
force-pushed
the
fix-assertion-in-server-exec-with-verbose-error-serialization
branch
from
c52aa69
to
0dabd85
Compare
Totktonada
reviewed
Oct 16, 2024
ylobankov
approved these changes
Oct 17, 2024
Totktonada
approved these changes
Oct 17, 2024
locker
deleted the
fix-assertion-in-server-exec-with-verbose-error-serialization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e6a2093 ("Add error handling at the server instance") broke assertion failure reporting in
server:exec()in case verbose error serialization is enabled in Tarantool (box_error_serialize_verbosecompatibility option is set tonew).The problem is with the verbose error serialization, a raw string raised with
error()is converted to an error object when marshalled through IPROTO while theserver:exec()code expects it to remain a string because it encodes the original error in JSON. As a result, we get a mangled error likeinstead of
To fix this issue, we revert the JSON encoding hack introduced by the aforementioned commit. In order not to reintroduce issue #242 fixed by that commit, we simply rollback the active transaction (if any) in case the executed function failed.
Closes #376