Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assert_items_exclude matcher #383

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add assert_items_exclude matcher #383

merged 1 commit into from
Oct 25, 2024

Conversation

ImeevMA
Copy link
Contributor

@ImeevMA ImeevMA commented Jul 9, 2024

This patch adds the assert_items_exclude(actual, expected, message) matcher. This matcher can be useful, for example, to verify that gc is working correctly.

locker
locker requested changes Oct 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
luatest/assertions.lua Outdated Show resolved Hide resolved
luatest/comparator.lua Outdated Show resolved Hide resolved
luatest/comparator.lua Outdated Show resolved Hide resolved
test/luaunit/assertions_test.lua Show resolved Hide resolved
@ImeevMA ImeevMA force-pushed the imeevma/gh-0-introduce-assert_items_exclude branch from bca550d to 290589e Compare October 22, 2024 07:27
@ImeevMA ImeevMA requested a review from locker October 22, 2024 07:35
@ImeevMA ImeevMA assigned locker and unassigned ImeevMA Oct 22, 2024
locker
locker reviewed Oct 22, 2024
View reviewed changes
luatest/comparator.lua Show resolved Hide resolved
test/luaunit/assertions_test.lua Show resolved Hide resolved
@locker locker assigned ImeevMA and unassigned locker Oct 22, 2024
@ImeevMA ImeevMA force-pushed the imeevma/gh-0-introduce-assert_items_exclude branch from 290589e to 33ee6fd Compare October 22, 2024 10:31
@ImeevMA
Add assert_items_exclude matcher
1a754c2 
This patch adds the `assert_items_exclude(actual, expected, message)`
matcher. This matcher can be useful, for example, to verify that gc is
working correctly.
@ImeevMA ImeevMA force-pushed the imeevma/gh-0-introduce-assert_items_exclude branch from 33ee6fd to 1a754c2 Compare October 22, 2024 10:36
@ImeevMA ImeevMA requested a review from locker October 22, 2024 10:54
@ImeevMA ImeevMA assigned locker and unassigned ImeevMA Oct 22, 2024
@locker locker assigned ylobankov and unassigned locker Oct 22, 2024
@locker locker requested review from ylobankov and Totktonada and removed request for ylobankov October 22, 2024 11:02
@locker locker assigned Totktonada and unassigned ylobankov Oct 24, 2024
Totktonada
Totktonada approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from my side. Thanks!

@Totktonada
Copy link
Member

Totktonada commented Oct 24, 2024 •
edited
Loading

assert_items_disjoint is maybe a more natural name.

I'm OK with the current assert_items_exclude, though.

@Totktonada Totktonada removed their assignment Oct 24, 2024
@locker locker merged commit 8254673 into master Oct 25, 2024
13 checks passed
@locker locker deleted the imeevma/gh-0-introduce-assert_items_exclude branch October 25, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locker locker locker approved these changes

@Totktonada Totktonada Totktonada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ImeevMA @Totktonada @locker @ylobankov