Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse custom net box URI (Unix socket) correctly #323

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Parse custom net box URI (Unix socket) correctly #323

merged 3 commits into from
Sep 8, 2023

Commits on Sep 7, 2023

  1. Parse custom net box URI (Unix socket) correctly 

    Until this moment, luatest didn't parse a custom net box URI correctly
in the case of a Unix socket if it was as follows:

    unix/:/tmp/foo1/bar1.iproto
    login:password@unix/:/tmp/foo2/bar2.iproto

So it created wrong directories for such sockets:

    unix/:/tmp/foo1/
    login:password@unix/:/tmp/foo2/

instead of correct ones:

    /tmp/foo1/
    /tmp/foo2/

Now this is fixed.

Fixes #313
    @ylobankov
    ylobankov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    ad498c4 View commit details
    Browse the repository at this point in the history

  2. Move creating required resources to start funcs 

    I don't like creating files, directories, whatever at the point of the
'class instance' initialization -- the `new` function. It's more logical
and gently to create all required resources on the start.
    @ylobankov
    ylobankov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    d17b959 View commit details
    Browse the repository at this point in the history

  3. Group some if conditions from Server:initialize` 

    The conditions like

    if a == nil and b == nil then
        c = 'something'
    end
    if a == nil and b then
        c = 'something else'
    end

going in a row look a little strange.

This patch groups similar conditions from the `Server:initialize`
function into the following construction:

    if a == nil then
        if b == nil then
            c = 'something'
        else
            c = 'something else'
        end
    end
    @ylobankov
    ylobankov committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    49a74b2 View commit details
    Browse the repository at this point in the history