Fixed invalid config parsing in argparse

tarantool · Dec 13, 2023 · 504a4ab · 504a4ab
1 parent be208ad
commit 504a4ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -35,6 +35,9 @@ Fixed
 
 - An error with ``cartridge.utils.version_is_at_least`` parsing.
 
+- Error in argparse when invalid config file was provided
+  (`#2169 <https://github.com/tarantool/cartridge/issues/2169>`_).
+
 -------------------------------------------------------------------------------
 [2.8.4] - 2023-10-31
 -------------------------------------------------------------------------------

diff --git a/cartridge/argparse.lua b/cartridge/argparse.lua
@@ -353,6 +353,10 @@ local function parse_file(filename, search_name)
     local ret = {}
     for _, section_name in ipairs(section_names) do
         local content = file_sections[section_name] or {}
+        if type(content) ~= 'table' then
+            return nil, ParseConfigError:new('Invalid content: options should be '..
+                'in format `name: value`')
+        end
 
         for argname, argvalue in pairs(content) do
             ret[argname:lower()] = argvalue