Bump testcontainers-java-tarantool to 1.2.0 #444
Conversation
nickkkccc
changed the title
nickkkccc
changed the title
pom.xml
Outdated
| @@ -264,7 +264,7 @@ | |||
| <dependency> | |||
| <groupId>io.tarantool</groupId> | |||
| <artifactId>testcontainers-java-tarantool</artifactId> | |||
| <version>1.0.1</version> | |||
| <version>1.0.2</version> | |||
There was a problem hiding this comment.
| <version>1.0.2</version> | |
| <version>1.1.0</version> |
nickkkccc
changed the title
- Bump testcontainers-java-tarantool version to 1.2.0 - Bump org.testcontainers:junit-jupiter version to 1.19.3 - CHANGELOG.md Closes #442
nickkkccc
requested review from
akudiyar,
ArtDu,
bitgorbovsky and
dkasimovskiy
| @@ -16,7 +16,7 @@ local ok, err = cartridge.cfg({ | |||
| 'app.roles.api_storage', | |||
| 'app.roles.custom', | |||
| }, | |||
| cluster_cookie = 'testapp-cluster-cookie', | |||
| cluster_cookie = 'secret-cluster-cookie', | |||
There was a problem hiding this comment.
it is default value and you can just remove this whole line
| @@ -56,7 +56,6 @@ public static void setUp() throws URISyntaxException, SSLException { | |||
| .withUsername("test_user") | |||
| .withPassword("test_password") | |||
| .withMemtxMemory(256 * 1024 * 1024) | |||
| .withDirectoryBinding(RESOURCE_PATH + "ssl") | |||
There was a problem hiding this comment.
you won't get files that are placed in org/testcontainers/containers/enterprise/ssl that needed for testing
There was a problem hiding this comment.
Fixed it for enterprise tests
Closes #442
| @@ -23,7 +23,6 @@ abstract class CartridgeMixedInstancesContainer { | |||
| "cartridge-java-test-mixed", | |||
| "cartridge/instances_mixed.yml", | |||
| "cartridge/topology_mixed.lua") | |||
| .withDirectoryBinding("cartridge") | |||
There was a problem hiding this comment.
I don't get how this works. Please explain how does a container get needed files?
There was a problem hiding this comment.
Previous version of the test containers (e.g., 1.0.1):
- Dependencies are downloaded on the system inside the container (gcc and others).
- The cartridge folder is a mapping of the
/appdirectory. - The cartridge folder is copied into the image as the
/appworking directory. This step is where the image is built. - Start the container and run the
cartridge buildcommand (dependency rocks are downloaded into the working directory at this point). Key point:the dependency rocks are downloaded into the/appdirectory related to the container. But docker looks at the cartridge folder that was mapped earlier in the build phase.
So binding works with 1.0.1
New version of testcontainers:
Copying the /cartridge directory and executing cartridge build happens during the image build phase. Key point: when using the .withDirectoryBinding method at the container startup stage, docker will look at the /cartridge directory that doesn't have the built rocks dependencies in it.
So binding doesn't work with new testcontainers.
Note the peculiarity of instance restarts in a cluster #106
I haven't forgotten about:
Related issues:
Closes #442