Replace streams with loops in DefaultMessagePackMapper #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waits for #438 to be merged. |
The stream-based code was more readable, but generated a lot of auxiliary classes and objects in runtime, making a significant GC overhead.
The stream-based code was more readable, but generated a lot of auxiliary classes and objects in runtime, making a significant GC overhead.
akudiyar
force-pushed
the
replace-streams-with-loops-tmp
branch
2 times, most recently
from
b89828d
to
5015fc6
Compare
Use ArrayList in converter maps to utilize sequential loops over the internal array instead of creating an iterator instance every time which adds additional GC pressure. Also improve maps encoding by creating an immediate zero-copy structure.
References to temporary objects were used in some places for request signatures calculation. Replace them with input parameters.
akudiyar
force-pushed
the
replace-streams-with-loops-tmp
branch
from
5015fc6
to
5f9e69c
Compare
|
Changelog line added in #453 I guess we can merge this PR as it is. |
ArtDu
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toValueandfromValuemethods in DefaultMessagePackMapper are hot spots as they are called on each request. This code was first written using Java streams, but while it allowed to make the code more readable, the streams are not very well-suitable for this task. The Java streams work better when we can execute the chained lambda functions in parallel on an executor, but are worse when replacing the normalforloops - they add significant overhead because of a lot of created auxiliary classes and objects in runtime.Now as the DefaultMessagePackMapper code is stable we can replace the stream-based code with more optimized loop-based code.