Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert datetime in Lua within OffsetDateTime in Java #437

Conversation

valery1707
Copy link
Contributor

@valery1707 valery1707 commented Oct 27, 2023

Since datetime in Lua supports working with offsets, it is logical to allow it to be converted to OffsetDateTime in Java to expand the possibilities of working with dates

I haven't forgotten about:

  • Tests
  • Changelog - do I need to add something into Changelog?
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues:

Part of #214

@ArtDu
Copy link
Contributor

ArtDu commented Oct 27, 2023

@valery1707 You are right that OffsetDateTime is valid for Tarantool. ZonedDateTime also valid for this.

I'll check your implementation later.

Also, check the CI cause it's red now

Since `datetime` in Lua supports working with offsets, it is logical to allow it to be converted to `OffsetDateTime` in Java to expand the possibilities of working with dates
@valery1707 valery1707 force-pushed the feature/converter/OffsetDateTime branch from e31b3d1 to cb4d1b9 Compare October 27, 2023 11:45
@valery1707
Copy link
Contributor Author

@ArtDu I update the code according to line length limit rule

@ArtDu
Copy link
Contributor

ArtDu commented Nov 3, 2023

@ArtDu I update the code according to line length limit rule

Good, but 2.10.6 tests are still red

@valery1707
Copy link
Contributor Author

@ArtDu I see, will analyze soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants