Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checking the current Tarantool version for minimum requirements #436

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

valery1707
Copy link
Contributor

The actual version will assume that version "3.2" is less than version "2.3" because 3 >= 2 && 2 >= 3 will computed as false.

I haven't forgotten about:

  • Tests
  • Changelog
    (seems that internal changes do not need to be reflected in Changelog)
  • Documentation
  • Commit messages comply with the guideline
  • Cleanup the code for review. See checklist

Related issues: none

@ArtDu ArtDu requested review from ArtDu and akudiyar October 27, 2023 11:28
Copy link
Contributor

@ArtDu ArtDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see any problems here

@valery1707
Copy link
Contributor Author

Check Tests Enterprise / tests (pull_request) are failed with
message:

Error:  Errors: 
Error:    SslClientITEnterprise.setUp:53 » DockerClient Could not build image: The command '/bin/sh -c curl https://curl.se/ca/cacert.pem -o /etc/pki/tls/certs/ca-bundle.crt &&     yum -y install wget &&     wget $DOWNLOAD_SDK_URI/$SDK_TGZ &&     mkdir ./tmp_sdk && tar -xf $SDK_TGZ -C ./tmp_sdk &&     mv ./tmp_sdk/tarantool-enterprise $SDK_TGT_DIR && rm $SDK_TGZ &&     cp $SDK_TGT_DIR/tarantool /usr/bin/tarantool' returned a non-zero code: 6
Error:    SslClientMTlsITEnterprise.setUp:54 » DockerClient Could not build image: The command '/bin/sh -c curl https://curl.se/ca/cacert.pem -o /etc/pki/tls/certs/ca-bundle.crt &&     yum -y install wget &&     wget $DOWNLOAD_SDK_URI/$SDK_TGZ &&     mkdir ./tmp_sdk && tar -xf $SDK_TGZ -C ./tmp_sdk &&     mv ./tmp_sdk/tarantool-enterprise $SDK_TGT_DIR && rm $SDK_TGZ &&     cp $SDK_TGT_DIR/tarantool /usr/bin/tarantool' returned a non-zero code: 6
[INFO] 
Error:  Tests run: 2, Failures: 0, Errors: 2, Skipped: 0

@akudiyar akudiyar added this pull request to the merge queue Oct 29, 2023
Merged via the queue into tarantool:master with commit 8600dd2 Oct 29, 2023
2 of 3 checks passed
@valery1707 valery1707 deleted the bugfix/test-version-check branch October 29, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants