Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connector: add fix for long socket paths #733

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

better0fdead
Copy link
Contributor

@better0fdead better0fdead commented Oct 28, 2022

Now relative path is used instead of real for console socket. It is used to prevent console socket path from being too long.
Before if connection addres was too long it returned an error, now it works.

Needed for that issue

I didn't forget about

  • Tests (CI is still green)
  • Changelog (Added)
  • Documentation (not worth to mention)

Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
Why don't you add a note about the change to the CHANGELOG?

@better0fdead
Copy link
Contributor Author

Hi! Thank you for the patch.
Why don't you add a note about the change to the CHANGELOG?

Sry, forgot, added

Now relative path is used instead of real for console socket.
It is used to prevent console socket path from being too long.
@LeonidVas LeonidVas merged commit 1e2d4a0 into master Nov 3, 2022
@LeonidVas LeonidVas deleted the better0fdead/no-gh-connect branch November 3, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants