New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clean URLs middleware with proper Content-Type headers and improv… #438

Open

kenzycodex wants to merge 1 commit into tapio:master from kenzycodex:feature/clean-urls

kenzycodex commented Jan 13, 2025

Clean URLs Middleware Enhancement

This PR adds a new middleware that provides clean URL routing for HTML files while maintaining proper HTTP headers and query parameter handling.

Features

Removes .html extensions from URLs (e.g., /about.html → /about)
Preserves query parameters during redirects
Sets proper UTF-8 charset in Content-Type headers
Handles trailing slashes consistently
Maintains backward compatibility with direct .html requests
Properly handles URL-encoded characters

Implementation Details

Added middleware/clean-urls.js with comprehensive URL handling
Includes full test coverage in test/clean-urls.test.js
Adds Cache-Control headers for redirects
Handles edge cases (root path, missing files)

Testing

All tests pass and cover:

Non-HTML file handling
Query parameter preservation
URL encoding preservation
Trailing slash handling
Root path resolution
Direct .html requests

Breaking Changes

None. This is an opt-in middleware that maintains compatibility with existing behavior.


          Add clean URLs middleware with proper Content-Type headers and improv…

d5b47ca

…ed query handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet