This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
add caching based on lat/lon with a configurable timeout #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking to prevent unnecessary lookups to the Dark Sky servers for both performance and cost reasons. For many use cases, this type of data doesn't need to be frequently updated.
FYI, from my local tests this changed the response time for cached responses from ~615ms to ~1. It's not a very robust cache, nor does it clean-up after itself atm. But given the type of data and the fact that it's optional should make it relatively safe to integrate.