Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native module for TangramES #1715

Open
saeedtabrizi opened this issue Oct 30, 2017 · 8 comments
Open

React Native module for TangramES #1715

saeedtabrizi opened this issue Oct 30, 2017 · 8 comments

Comments

@saeedtabrizi
Copy link

Hi
Is there any plan to develop the React Native module for TangramES ?
I did write a package for supporting TangramES module in ReactNative .
May i push it here ?
Thanks

@tallytalwar
Copy link
Member

Hey @saeedtabrizi

Thanks for the suggestion and the work to get a React Native module for TangramES. Can you please file a PR with this work, even though this was not on our roadmap, this will definitely be a good add on to suite of tools. Also we love community contributions, so thanks again for that.

Our team will give it a review once the PR is ready.

@saeedtabrizi
Copy link
Author

Hi @tallytalwar
Thanks for your comments and contribution welcome .
OK , i will push it asap (some clean up needed exactly).

@saeedtabrizi
Copy link
Author

Hi @tallytalwar
Now i have an PR #1799 for react native module .
Please inform me if any modification needed to accept the PR .
Thanks .
Saeed

@tallytalwar
Copy link
Member

Thanks @saeedtabrizi

Me or someone from our team will review it. Its a lot of code to review so might take some time :D.

@saeedtabrizi
Copy link
Author

Hi @tallytalwar
Is there any good news here ?

@tallytalwar
Copy link
Member

@saeedtabrizi sorry about the delay here. All (3) the current active developers on the project are busy with other priority tasks, but this is still under our radar, the team wants to have maximum platform coverage, so will keep you posted. Thanks for the patience.

@P0oOOOo0YA
Copy link

@tallytalwar Although the webgl version is available but it would be great if react-native could benefit from direct opengl rendering. Is threre any progress on the opengl side?

@frozencap
Copy link

any news

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants