-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tailscale: use V2 client for Webhooks #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxtoacart
force-pushed
the
percy/webhooks-client-v2-for-real
branch
from
August 3, 2024 19:46
886dcc0
to
d0c3f6c
Compare
Acceptance test passed - https://github.com/tailscale/corp/actions/runs/10225845945/job/28295382372 |
oxtoacart
force-pushed
the
percy/webhooks-client-v2-for-real
branch
from
August 5, 2024 14:07
d0c3f6c
to
1b142fa
Compare
Acceptance test passed. |
oxtoacart
force-pushed
the
percy/webhooks-client-v2-for-real
branch
from
August 6, 2024 16:06
1b142fa
to
2274c08
Compare
mpminardi
reviewed
Aug 6, 2024
go.mod
Outdated
@@ -10,7 +10,7 @@ require ( | |||
github.com/stretchr/testify v1.9.0 | |||
github.com/tailscale/hujson v0.0.0-20221223112325-20486734a56a | |||
github.com/tailscale/tailscale-client-go v1.17.1-0.20240729175651-90a1e935cc19 | |||
github.com/tailscale/tailscale-client-go/v2 v2.0.0-20240802213233-7518e6604513 | |||
github.com/tailscale/tailscale-client-go/v2 v2.0.0-20240805140419-bbf53147c21e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update to ref from main before merging
mpminardi
approved these changes
Aug 6, 2024
Updates tailscale/corp#21867 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/webhooks-client-v2-for-real
branch
from
August 6, 2024 20:59
2274c08
to
c3687c6
Compare
Acceptance passed after rebase, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tailscale/corp#21867
Depends on tailscale/tailscale-client-go#91