Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale: use V2 client for Webhooks #391

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

oxtoacart
Copy link
Contributor

@oxtoacart oxtoacart commented Aug 3, 2024

Updates tailscale/corp#21867

Depends on tailscale/tailscale-client-go#91

@oxtoacart oxtoacart force-pushed the percy/webhooks-client-v2-for-real branch from 886dcc0 to d0c3f6c Compare August 3, 2024 19:46
@oxtoacart
Copy link
Contributor Author

@oxtoacart oxtoacart changed the base branch from main to percy/webhooks-client-v2 August 3, 2024 19:50
@oxtoacart oxtoacart force-pushed the percy/webhooks-client-v2-for-real branch from d0c3f6c to 1b142fa Compare August 5, 2024 14:07
@oxtoacart
Copy link
Contributor Author

Acceptance test passed.

Base automatically changed from percy/webhooks-client-v2 to main August 6, 2024 16:04
@oxtoacart oxtoacart force-pushed the percy/webhooks-client-v2-for-real branch from 1b142fa to 2274c08 Compare August 6, 2024 16:06
go.mod Outdated
@@ -10,7 +10,7 @@ require (
github.com/stretchr/testify v1.9.0
github.com/tailscale/hujson v0.0.0-20221223112325-20486734a56a
github.com/tailscale/tailscale-client-go v1.17.1-0.20240729175651-90a1e935cc19
github.com/tailscale/tailscale-client-go/v2 v2.0.0-20240802213233-7518e6604513
github.com/tailscale/tailscale-client-go/v2 v2.0.0-20240805140419-bbf53147c21e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update to ref from main before merging

@oxtoacart oxtoacart force-pushed the percy/webhooks-client-v2-for-real branch from 2274c08 to c3687c6 Compare August 6, 2024 20:59
@oxtoacart
Copy link
Contributor Author

Acceptance passed after rebase, merging.

@oxtoacart oxtoacart merged commit a5e8ac1 into main Aug 6, 2024
4 checks passed
@oxtoacart oxtoacart deleted the percy/webhooks-client-v2-for-real branch August 6, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants