Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tailnet lock fields to device structs #125

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

hosom
Copy link
Contributor

@hosom hosom commented Nov 25, 2024

The client doesn't return the values for tailnetLockError or tailnetLockKey, and these would be great to include, since they're included by default when listing devices anyway.

@knyar knyar requested a review from oxtoacart November 26, 2024 16:33
Signed-off-by: hosom <[email protected]>
Copy link
Contributor

@oxtoacart oxtoacart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The change itself looks good. Can you please also update the test to include these fields?

@hosom
Copy link
Contributor Author

hosom commented Dec 3, 2024

Thank you!

The change itself looks good. Can you please also update the test to include these fields?

Done! Thanks!

@knyar knyar merged commit 04b7d00 into tailscale:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants