tailscale: polish API and documentation in preparation for tagging re… #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpminardi
approved these changes
Aug 28, 2024
v2/README.md
Outdated
| Tailnet: tailnet, | ||
| } | ||
|
|
||
| // List all your devices |
There was a problem hiding this comment.
Nit: maybe: List all devices in the tailnet
README.md
Outdated
| @@ -4,12 +4,13 @@ | |||
| [](https://goreportcard.com/report/github.com/tailscale/tailscale-client-go) | |||
|  | |||
|
|
|||
| DEPRECATED - V1 is no longer being maintained. The [V2 SDK](v2) provides a full wrapper around the V2 [Tailscale API](https://tailscale.com/api). | |||
There was a problem hiding this comment.
Is "full" here implying that we've got complete / full coverage of the V2 endpoints? If so we might want to drop it from this sentence since we don't quite cover the entire V2 API (e.g., user invites are not in the client as an example).
…lease Updates tailscale/corp#21867 Signed-off-by: Percy Wegmann <[email protected]>
oxtoacart
force-pushed
the
percy/v2-final-cleanup
branch
from
7548897 to
0b91117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lease
Updates tailscale/corp#21867