-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use new getListenerFromPlugin signature #83
Conversation
14e06e5
to
cbd3bb3
Compare
I think that in each of the getXXXListener functions the following correction should be made, otherwise I can't compile the plugin code
caddy.JoinNetworkAddress() returns a string, so that's definitely not correct, but it will probably be fine after changing it to: ...
na, err := caddy.ParseNetworkAddress(caddy.JoinNetworkAddress(network, host, portRange))
... EDIT: Since I am actively using the caddy-tailscale module, I have to revert to the caddy commit from before the ListenerFunc declaration change for now :-( |
Last commit 2 months ago, I wonder if project caddy-tailscale is still active/alive? After the aforementioned significant change in the caddy function declaration, building this plugin in its current form is impossible. |
Signed-off-by: Aaron Paterson <[email protected]>
Updates tailscale/tailscale#8905 Signed-off-by: Will Norris <[email protected]> Signed-off-by: Aaron Paterson <[email protected]>
This reverts commit 48c1c24. Signed-off-by: Aaron Paterson <[email protected]>
Signed-off-by: Aaron Paterson <[email protected]>
d423cd9
to
665bec7
Compare
My apologies, and thanks for #89 . The missing |
this is for when caddyserver/caddy#6651 gets released