Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update rust version #3043

Merged
merged 11 commits into from
Nov 2, 2024
Merged

chore: update rust version #3043

merged 11 commits into from
Nov 2, 2024

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Oct 20, 2024

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.94%. Comparing base (d63b288) to head (088a416).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/json/borrow.rs 0.00% 3 Missing ⚠️
src/cli/fmt.rs 0.00% 1 Missing ⚠️
src/core/grpc/request_template.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3043      +/-   ##
==========================================
- Coverage   87.05%   86.94%   -0.12%     
==========================================
  Files         280      280              
  Lines       27478    27291     -187     
==========================================
- Hits        23921    23727     -194     
- Misses       3557     3564       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Oct 20, 2024
@meskill meskill marked this pull request as draft October 21, 2024 09:29
Copy link

github-actions bot commented Oct 26, 2024

🐰 Bencher Report

Branch3043/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,095,200.00
group_by📈 view plot
⚠️ NO THRESHOLD
487.04
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.98
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.07
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
36.02
input/args.root📈 view plot
⚠️ NO THRESHOLD
38.07
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.70
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
33.75
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.59
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.21
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
35.73
input/value.root📈 view plot
⚠️ NO THRESHOLD
41.69
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.34
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
11.19
synth_nested📈 view plot
⚠️ NO THRESHOLD
94,749.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
42,152.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,881.90
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,505,700.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
389,500.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
127,630.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
61,256.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
14,998.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,085.90
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
699.17
🐰 View full continuous benchmarking report in Bencher

@meskill meskill marked this pull request as ready for review October 26, 2024 10:58
@tusharmath tusharmath enabled auto-merge (squash) October 28, 2024 10:34
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Nov 2, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label Nov 2, 2024
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label Nov 2, 2024
@tusharmath tusharmath merged commit cc911a3 into main Nov 2, 2024
29 of 31 checks passed
@tusharmath tusharmath deleted the chore/toolchain-update branch November 2, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine tasks like conversions, reorganization, and maintenance work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants