Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): Fix Incorrect Argument Order in Foundry Verification Command #15134

Closed
wants to merge 1 commit into from
Closed

fix(website): Fix Incorrect Argument Order in Foundry Verification Command #15134

wants to merge 1 commit into from

Conversation

paulallensuxs
Copy link
Contributor

@paulallensuxs paulallensuxs commented Nov 4, 2023

Description:

This pull request corrects an error in the documentation where the command provided for verifying contracts using Foundry has its arguments out of order. This causes the command to fail when users attempt to verify their contracts. Closes #15133.

Changes Made:

  • Adjusted the order of arguments in the forge create command to match the required format by Foundry.

Files Changed:

  • docs/guides/verify-contract.mdx

Proposed Changes:

- forge create --rpc-url https://rpc.jolnir.taiko.xyz --private-key $devTestnetPrivateKey src/Contract.sol:SimpleStorage --verify --verifier blockscout --verifier-url https://blockscoutapi.jolnir.taiko.xyz/api\?
+ forge create --rpc-url https://rpc.jolnir.taiko.xyz --private-key $devTestnetPrivateKey --verify --verifier blockscout --verifier-url https://blockscoutapi.jolnir.taiko.xyz/api src/Contract.sol:SimpleStorage

Testing:

Before submitting this pull request, I tested the updated command in my local environment to ensure that it executes without errors and initiates the contract verification process as expected.

Additional Notes:

Users should replace $devTestnetPrivateKey with their actual private key and src/Contract.sol:SimpleStorage with the appropriate path and contract name for their use case. The documentation now reflects the correct usage of the command in accordance with Foundry's requirements.

Copy link

vercel bot commented Nov 4, 2023

@paulallensuxs is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
bridge-ui-v2-internal ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2023 3:30am

@dantaik dantaik changed the title Fix Incorrect Argument Order in Foundry Verification Command fix(website): Fix Incorrect Argument Order in Foundry Verification Command Nov 9, 2023
@2manslkh
Copy link
Contributor

There is no issue with the current implementation.

@2manslkh 2manslkh closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation Command for Contract Verification Fails on Execution
3 participants