Skip to content

fix lint

fix lint #8

GitHub Actions / Clippy (beta) succeeded Oct 20, 2023 in 0s

Clippy (beta)

22 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 22
Note 0
Help 0

Versions

  • rustc 1.66.0 (69f9c33d7 2022-12-12)
  • cargo 1.66.0 (d65d197ad 2022-11-15)
  • clippy 0.1.66 (69f9c33 2022-12-12)

Annotations

Check warning on line 113 in halo2_gadgets/src/sha256/table16/util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/util.rs:113:31
    |
113 |     let carry = sum.map(|sum| (sum >> 32) as u64);
    |                               ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 180 in halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57
    |
180 |                 || carry.map(|carry| pallas::Base::from(carry as u64)),
    |                                                         ^^^^^^^^^^^^ help: try: `carry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 264 in halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57
    |
264 |                 || carry.map(|carry| pallas::Base::from(carry as u64)),
    |                                                         ^^^^^^^^^^^^ help: try: `carry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 56 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34
   |
56 |             + DECOMPOSE_0_ROWS * (word_idx - 62) as usize
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 50 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34
   |
50 |             + SUBREGION_3_WORD * (word_idx - 49) as usize
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 43 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47
   |
43 |         SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 786 in halo2_gadgets/src/sha256/table16/compression/compression_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65
    |
786 |                 || h_prime_carry.map(|value| pallas::Base::from(value as u64)),
    |                                                                 ^^^^^^^^^^^^ help: try: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 114 in halo2_gadgets/src/sha256/table16/compression/compression_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13
    |
114 |             (idx as usize) * SUBREGION_MAIN_WORD
    |             ^^^^^^^^^^^^^^ help: try: `idx`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

Check warning on line 147 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/benches/sha256.rs:147:35
    |
147 |     let mut proof_fs = File::open(&proof_path).expect("couldn't load sha256_proof");
    |                                   ^^^^^^^^^^^ help: change this to: `proof_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 143 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/benches/sha256.rs:143:37
    |
143 |         let mut file = File::create(&proof_path).expect("Failed to create sha256_proof");
    |                                     ^^^^^^^^^^^ help: change this to: `proof_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 131 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/benches/sha256.rs:131:19
    |
131 |     if File::open(&proof_path).is_err() {
    |                   ^^^^^^^^^^^ help: change this to: `proof_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 104 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> halo2_gadgets/benches/sha256.rs:104:32
    |
104 |     let params_fs = File::open(&params_path).expect("couldn't load sha256_params");
    |                                ^^^^^^^^^^^^ help: change this to: `params_path`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 98 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> halo2_gadgets/benches/sha256.rs:98:37
   |
98 |         let mut file = File::create(&params_path).expect("Failed to create sha256_params");
   |                                     ^^^^^^^^^^^^ help: change this to: `params_path`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 93 in halo2_gadgets/benches/sha256.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
  --> halo2_gadgets/benches/sha256.rs:93:19
   |
93 |     if File::open(&params_path).is_err() {
   |                   ^^^^^^^^^^^^ help: change this to: `params_path`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

Check warning on line 113 in halo2_gadgets/src/sha256/table16/util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/util.rs:113:31
    |
113 |     let carry = sum.map(|sum| (sum >> 32) as u64);
    |                               ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 180 in halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57
    |
180 |                 || carry.map(|carry| pallas::Base::from(carry as u64)),
    |                                                         ^^^^^^^^^^^^ help: try: `carry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 264 in halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57
    |
264 |                 || carry.map(|carry| pallas::Base::from(carry as u64)),
    |                                                         ^^^^^^^^^^^^ help: try: `carry`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 56 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34
   |
56 |             + DECOMPOSE_0_ROWS * (word_idx - 62) as usize
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 50 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34
   |
50 |             + SUBREGION_3_WORD * (word_idx - 49) as usize
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 43 in halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
  --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47
   |
43 |         SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize
   |                                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 786 in halo2_gadgets/src/sha256/table16/compression/compression_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`u64` -> `u64`)

warning: casting to the same type is unnecessary (`u64` -> `u64`)
   --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65
    |
786 |                 || h_prime_carry.map(|value| pallas::Base::from(value as u64)),
    |                                                                 ^^^^^^^^^^^^ help: try: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

Check warning on line 114 in halo2_gadgets/src/sha256/table16/compression/compression_util.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

casting to the same type is unnecessary (`usize` -> `usize`)

warning: casting to the same type is unnecessary (`usize` -> `usize`)
   --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13
    |
114 |             (idx as usize) * SUBREGION_MAIN_WORD
    |             ^^^^^^^^^^^^^^ help: try: `idx`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`