fix poly degree 0 underflow #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work! I specially like the test case 💫 |
einar-taiko
approved these changes
Oct 16, 2023
einar-taiko
approved these changes
Oct 20, 2023
halo2_proofs/src/plonk/evaluation.rs
Outdated
| let mut idx = 0; | ||
| if degree != 0 { | ||
| // same as unstable degree.ilog() | ||
| idx = (degree as f32).log2().floor() as usize; |
There was a problem hiding this comment.
Good catch with the versioning.
I would prefer idx = (31 - (degree as u32).leading_zeros()) as usize over introducing floating-point math.
There was a problem hiding this comment.
NP, let's back to the origin code :)
I guess it should be ok, let me try |
|
All CI & lint issues are addressed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
substract underflow if poly's degree is 0, which happens if we have an empty/constant value gate.
Another issue is if I don't update the rust-toolchain to 1.66, I got: