error: the borrowed expression implements the required traits --> halo2_proofs/src/dev/graph/layout.rs:203:65 | 203 | root.draw(&Rectangle::new([top_left, bottom_right], &BLACK))?; | ^^^^^^ help: change this to: `BLACK` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_proofs/src/dev/graph/layout.rs#L187

error: the borrowed expression implements the required traits --> halo2_proofs/src/dev/graph/layout.rs:187:13 | 187 | &BLACK, | ^^^^^^ help: change this to: `BLACK` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`

Test on ubuntu-latest

The process '/home/runner/.cargo/bin/cargo' failed with exit code 101

Test on windows-latest

The operation was canceled.

Test on macOS-latest

The operation was canceled.

Rustfmt

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Rustfmt

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Rustfmt

the borrowed expression implements the required traits: halo2_proofs/src/dev/graph/layout.rs#L203

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev/graph/layout.rs:203:65 | 203 | root.draw(&Rectangle::new([top_left, bottom_right], &BLACK))?; | ^^^^^^ help: change this to: `BLACK` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_proofs/src/dev/graph/layout.rs#L187

warning: the borrowed expression implements the required traits --> halo2_proofs/src/dev/graph/layout.rs:187:13 | 187 | &BLACK, | ^^^^^^ help: change this to: `BLACK` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/util.rs#L113

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/util.rs:113:31 | 113 | let carry = sum.map(|sum| (sum >> 32) as u64); | ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L180

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57 | 180 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L264

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57 | 264 | || carry.map(|carry| pallas::Base::from(carry as u64)), | ^^^^^^^^^^^^ help: try: `carry` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L56

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34 | 56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L50

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34 | 50 | + SUBREGION_3_WORD * (word_idx - 49) as usize | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L43

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47 | 43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L786

warning: casting to the same type is unnecessary (`u64` -> `u64`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65 | 786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)), | ^^^^^^^^^^^^ help: try: `value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`usize` -> `usize`): halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L114

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13 | 114 | (idx as usize) * SUBREGION_MAIN_WORD | ^^^^^^^^^^^^^^ help: try: `idx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L147

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:147:35 | 147 | let mut proof_fs = File::open(&proof_path).expect("couldn't load sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L143

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:143:37 | 143 | let mut file = File::create(&proof_path).expect("Failed to create sha256_proof"); | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L131

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:131:19 | 131 | if File::open(&proof_path).is_err() { | ^^^^^^^^^^^ help: change this to: `proof_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L104

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:104:32 | 104 | let params_fs = File::open(&params_path).expect("couldn't load sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L98

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:98:37 | 98 | let mut file = File::create(&params_path).expect("Failed to create sha256_params"); | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: halo2_gadgets/benches/sha256.rs#L93

warning: the borrowed expression implements the required traits --> halo2_gadgets/benches/sha256.rs:93:19 | 93 | if File::open(&params_path).is_err() { | ^^^^^^^^^^^^ help: change this to: `params_path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

casting to the same type is unnecessary (`u64` -> `u64`): halo2_gadgets/src/sha256/table16/util.rs#L113