update logic & fix fmt #5
smtmfftAnnotations
68 errors and 203 warnings
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L203
error: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:203:65
|
203 | root.draw(&Rectangle::new([top_left, bottom_right], &BLACK))?;
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L187
error: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:187:13
|
187 | &BLACK,
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L458
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:458:27
|
458 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L444
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:444:27
|
444 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L432
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:432:25
|
432 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L431
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:431:25
|
431 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L427
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:427:27
|
427 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L284
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:284:27
|
284 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L270
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:270:27
|
270 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L258
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:258:25
|
258 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L257
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:257:25
|
257 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L253
error: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:253:27
|
253 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L104
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:104:49
|
104 | let root_pow = root.pow_vartime(&[offset as u64]);
| ^^^^^^^^^^^^^^^^ help: change this to: `[offset as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/kzg/commitment.rs#L100
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/kzg/commitment.rs:100:43
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L100
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:100:41
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^^^^ help: change this to: `[n as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L78
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:78:40
|
78 | current_g *= s.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L620
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:620:30
|
620 | .pow_vartime(&[(rotation.0 as i64).unsigned_abs()]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(rotation.0 as i64).unsigned_abs()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L616
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:616:52
|
616 | point *= &self.get_omega().pow_vartime(&[rotation.0 as u64]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[rotation.0 as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L550
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:550:45
|
550 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/poly/domain.rs#L195
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/poly/domain.rs:195:34
|
195 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.extended_len() >> self.k)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L103
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:103:53
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L103
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:103:51
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L102
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:102:46
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L102
error: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:102:44
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L249
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:249:26
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L249
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:249:24
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L180
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:180:26
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L180
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:180:24
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/prover.rs#L554
error: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/prover.rs:554:22
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L554
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:554:20
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/verifier.rs#L182
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/verifier.rs:182:46
|
182 | ... .pow_vartime(&[(chunk_index * chunk_len) as u64]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(chunk_index * chunk_len) as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/prover.rs#L129
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/prover.rs:129:74
|
129 | let mut deltaomega = deltaomega * &omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L190
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:190:60
|
190 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L178
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:178:49
|
178 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L128
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:128:60
|
128 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L116
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:116:49
|
116 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/plonk/lookup/prover.rs#L446
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/plonk/lookup/prover.rs:446:35
|
446 | permuted_table_coeffs[repeated_input_rows.pop().unwrap() as usize] = *coeff;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `repeated_input_rows.pop().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/evaluation.rs#L694
error: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/evaluation.rs:694:57
|
694 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L443
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:443:17
|
443 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L441
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:441:21
|
441 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L280
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:280:17
|
280 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L278
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:278:21
|
278 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L187
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:187:17
|
187 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L185
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:185:21
|
185 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/recursive.rs#L107
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/recursive.rs:107:43
|
107 | let mut w = o.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L87
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:87:33
|
87 | let stages = get_stages(n as usize, vec![]);
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L264
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:264:17
|
264 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L262
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:262:21
|
262 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L232
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:232:39
|
232 | let new_omega = omega.pow_vartime(&[split_m as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[split_m as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L201
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:201:22
|
201 | let sub_n = n >> log_split as usize;
| ^^^^^^^^^^^^^^^^^^ help: try: `log_split`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L196
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:196:13
|
196 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L184
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:184:57
|
184 | let mut w_n = high_degree_omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L180
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:180:47
|
180 | let high_degree_omega = omega.pow_vartime(&[(1 << sparse_degree) as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(1 << sparse_degree) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L173
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:173:45
|
173 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L169
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:169:41
|
169 | let mut twiddle_lut = vec![F::ZERO; (low_degree_lut_len + high_degree_lut_len) as usize];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(low_degree_lut_len + high_degree_lut_len)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L157
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:157:45
|
157 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L128
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:128:21
|
128 | let omega_idx = sub_fft_offset as usize;
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sub_fft_offset`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L48
error: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:48:45
|
48 | let w_m: Scalar = omega.pow_vartime(&[u64::from(n / (2 * m)), 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[u64::from(n / (2 * m)), 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:33
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^ help: try: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:20
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^^ help: try: `rk`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L24
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L47
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:47:33
|
47 | let mut twiddle_chunk = (n / 2) as usize;
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L36
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:36:32
|
36 | let twiddles: Vec<_> = (0..(n / 2) as usize)
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L24
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
iterating on a map's values:
halo2_proofs/src/circuit/floor_planner/v1.rs#L83
error: iterating on a map's values
--> halo2_proofs/src/circuit/floor_planner/v1.rs:83:36
|
83 | let first_unassigned_row = column_allocations
| ____________________________________^
84 | | .iter()
85 | | .map(|(_, a)| a.unbounded_interval_start())
| |_______________________________________________________^ help: try: `column_allocations.values().map(|a| a.unbounded_interval_start())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `-D clippy::iter-kv-map` implied by `-D warnings`
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/arithmetic.rs#L313
error: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/arithmetic.rs:313:21
|
313 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L262
error: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:262:72
|
262 | out[0] = evaluate(poly, point) * point.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L213
error: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:213:48
|
213 | let n_inv = C::Scalar::TWO_INV.pow_vartime(&[k as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[k as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L203
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:203:65
|
203 | root.draw(&Rectangle::new([top_left, bottom_right], &BLACK))?;
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L187
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:187:13
|
187 | &BLACK,
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L458
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:458:27
|
458 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L444
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:444:27
|
444 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L432
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:432:25
|
432 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L431
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:431:25
|
431 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L427
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:427:27
|
427 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L284
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:284:27
|
284 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L270
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:270:27
|
270 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L258
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:258:25
|
258 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L257
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:257:25
|
257 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L253
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:253:27
|
253 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L104
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:104:49
|
104 | let root_pow = root.pow_vartime(&[offset as u64]);
| ^^^^^^^^^^^^^^^^ help: change this to: `[offset as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/kzg/commitment.rs#L100
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/kzg/commitment.rs:100:43
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L100
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:100:41
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^^^^ help: change this to: `[n as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L78
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:78:40
|
78 | current_g *= s.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/poly/domain.rs#L938
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/poly/domain.rs:938:21
|
938 | poly.resize(domain.extended_len() as usize, Scalar::zero());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/poly/domain.rs#L880
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/poly/domain.rs:880:21
|
880 | poly.resize(domain.extended_len() as usize, Scalar::zero());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `domain.extended_len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L784
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:784:20
|
784 | let xn = x.pow(&[8, 0, 0, 0]);
| ^^^^^^^^^^^^^ help: change this to: `[8, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L774
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:774:38
|
774 | points.push(domain.omega.pow(&[i, 0, 0, 0]));
| ^^^^^^^^^^^^^ help: change this to: `[i, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L620
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:620:30
|
620 | .pow_vartime(&[(rotation.0 as i64).unsigned_abs()]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(rotation.0 as i64).unsigned_abs()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L616
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:616:52
|
616 | point *= &self.get_omega().pow_vartime(&[rotation.0 as u64]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[rotation.0 as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L550
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:550:45
|
550 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/poly/domain.rs#L195
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/poly/domain.rs:195:34
|
195 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.extended_len() >> self.k)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L103
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:103:53
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L103
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:103:51
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L102
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:102:46
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L102
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:102:44
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L249
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:249:26
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L249
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:249:24
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:180:26
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L180
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:180:24
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/prover.rs#L554
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/prover.rs:554:22
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L554
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:554:20
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/verifier.rs#L182
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/verifier.rs:182:46
|
182 | ... .pow_vartime(&[(chunk_index * chunk_len) as u64]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(chunk_index * chunk_len) as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/prover.rs#L129
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/prover.rs:129:74
|
129 | let mut deltaomega = deltaomega * &omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L190
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:190:60
|
190 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L178
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:178:49
|
178 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L128
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:128:60
|
128 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L116
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:116:49
|
116 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/plonk/lookup/prover.rs#L446
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/plonk/lookup/prover.rs:446:35
|
446 | permuted_table_coeffs[repeated_input_rows.pop().unwrap() as usize] = *coeff;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `repeated_input_rows.pop().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/evaluation.rs#L694
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/evaluation.rs:694:57
|
694 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
boolean to int conversion using if:
halo2_proofs/src/plonk/assigned.rs#L616
warning: boolean to int conversion using if
--> halo2_proofs/src/plonk/assigned.rs:616:26
|
616 | cmp::max(if num_unary > 0 { 1 } else { 0 }, num_binary + 1)),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(num_unary > 0)`
|
= note: `(num_unary > 0) as usize` or `(num_unary > 0).into()` can also be valid options
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if
= note: `-W clippy::bool-to-int-with-if` implied by `-W clippy::all`
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
halo2_proofs/src/fft.rs#L263
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> halo2_proofs/src/fft.rs:263:33
|
263 | best_fft(&mut a, omega, k as u32, data, false);
| ^^^^^^^^ help: try: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L443
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:443:17
|
443 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L441
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:441:21
|
441 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L280
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:280:17
|
280 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L278
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:278:21
|
278 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L187
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:187:17
|
187 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L185
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:185:21
|
185 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/recursive.rs#L107
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/recursive.rs:107:43
|
107 | let mut w = o.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L87
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:87:33
|
87 | let stages = get_stages(n as usize, vec![]);
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L264
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:264:17
|
264 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L232
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:232:39
|
232 | let new_omega = omega.pow_vartime(&[split_m as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[split_m as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L201
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:201:22
|
201 | let sub_n = n >> log_split as usize;
| ^^^^^^^^^^^^^^^^^^ help: try: `log_split`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L196
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:196:13
|
196 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L184
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:184:57
|
184 | let mut w_n = high_degree_omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L180
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:180:47
|
180 | let high_degree_omega = omega.pow_vartime(&[(1 << sparse_degree) as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(1 << sparse_degree) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L173
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:173:45
|
173 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L169
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:169:41
|
169 | let mut twiddle_lut = vec![F::ZERO; (low_degree_lut_len + high_degree_lut_len) as usize];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(low_degree_lut_len + high_degree_lut_len)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L157
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:157:45
|
157 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L128
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:128:21
|
128 | let omega_idx = sub_fft_offset as usize;
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sub_fft_offset`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L48
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:48:45
|
48 | let w_m: Scalar = omega.pow_vartime(&[u64::from(n / (2 * m)), 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[u64::from(n / (2 * m)), 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:33
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^ help: try: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:20
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^^ help: try: `rk`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L24
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L47
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:47:33
|
47 | let mut twiddle_chunk = (n / 2) as usize;
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L36
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:36:32
|
36 | let twiddles: Vec<_> = (0..(n / 2) as usize)
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L24
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
iterating on a map's values:
halo2_proofs/src/circuit/floor_planner/v1.rs#L83
warning: iterating on a map's values
--> halo2_proofs/src/circuit/floor_planner/v1.rs:83:36
|
83 | let first_unassigned_row = column_allocations
| ____________________________________^
84 | | .iter()
85 | | .map(|(_, a)| a.unbounded_interval_start())
| |_______________________________________________________^ help: try: `column_allocations.values().map(|a| a.unbounded_interval_start())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `-W clippy::iter-kv-map` implied by `-W clippy::all`
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/arithmetic.rs#L313
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/arithmetic.rs:313:21
|
313 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L262
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:262:72
|
262 | out[0] = evaluate(poly, point) * point.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L213
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:213:48
|
213 | let n_inv = C::Scalar::TWO_INV.pow_vartime(&[k as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[k as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sinsemilla.rs#L200
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sinsemilla.rs:200:30
|
200 | assert!(num_words <= piece_max_num_words as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/util.rs#L113
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/util.rs:113:31
|
113 | let carry = sum.map(|sum| (sum >> 32) as u64);
| ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57
|
180 | || carry.map(|carry| pallas::Base::from(carry as u64)),
| ^^^^^^^^^^^^ help: try: `carry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L264
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57
|
264 | || carry.map(|carry| pallas::Base::from(carry as u64)),
| ^^^^^^^^^^^^ help: try: `carry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L56
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34
|
56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L50
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34
|
50 | + SUBREGION_3_WORD * (word_idx - 49) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L43
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47
|
43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L786
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65
|
786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)),
| ^^^^^^^^^^^^ help: try: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L114
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13
|
114 | (idx as usize) * SUBREGION_MAIN_WORD
| ^^^^^^^^^^^^^^ help: try: `idx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
|
|
boolean to int conversion using if:
halo2_proofs/benches/commit_zk.rs#L26
warning: boolean to int conversion using if
--> halo2_proofs/benches/commit_zk.rs:26:32
|
26 | let n_chunks = n_threads + if n % n_threads != 0 { 1 } else { 0 };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(n % n_threads != 0)`
|
= note: `(n % n_threads != 0) as usize` or `(n % n_threads != 0).into()` can also be valid options
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if
= note: `-W clippy::bool-to-int-with-if` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L51
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25
|
51 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L25
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25
|
25 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
halo2_proofs/benches/fft.rs#L26
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> halo2_proofs/benches/fft.rs:26:41
|
26 | best_fft(&mut a, omega, k as u32, data, false);
| ^^^^^^^^ help: try: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L513
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:513:77
|
513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L473
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:473:73
|
473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L447
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:447:62
|
447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
boolean to int conversion using if:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L493
warning: boolean to int conversion using if
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:493:53
|
493 | .fold(0, |acc, b| 2 * acc + if b { 1 } else { 0 })
| ^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(b)`
|
= note: `b as usize` or `b.into()` can also be valid options
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if
= note: `-W clippy::bool-to-int-with-if` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L397
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42
|
397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L392
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37
|
392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L147
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:147:35
|
147 | let mut proof_fs = File::open(&proof_path).expect("couldn't load sha256_proof");
| ^^^^^^^^^^^ help: change this to: `proof_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L375
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68
|
375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0]));
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L143
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:143:37
|
143 | let mut file = File::create(&proof_path).expect("Failed to create sha256_proof");
| ^^^^^^^^^^^ help: change this to: `proof_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L131
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:131:19
|
131 | if File::open(&proof_path).is_err() {
| ^^^^^^^^^^^ help: change this to: `proof_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L104
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:104:32
|
104 | let params_fs = File::open(¶ms_path).expect("couldn't load sha256_params");
| ^^^^^^^^^^^^ help: change this to: `params_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L98
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:98:37
|
98 | let mut file = File::create(¶ms_path).expect("Failed to create sha256_params");
| ^^^^^^^^^^^^ help: change this to: `params_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/sha256.rs#L93
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/sha256.rs:93:19
|
93 | if File::open(¶ms_path).is_err() {
| ^^^^^^^^^^^^ help: change this to: `params_path`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/benches/poseidon.rs#L138
warning: the borrowed expression implements the required traits
--> halo2_gadgets/benches/poseidon.rs:138:25
|
138 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sinsemilla.rs#L200
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sinsemilla.rs:200:30
|
200 | assert!(num_words <= piece_max_num_words as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `piece_max_num_words`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/util.rs#L113
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/util.rs:113:31
|
113 | let carry = sum.map(|sum| (sum >> 32) as u64);
| ^^^^^^^^^^^^^^^^^^ help: try: `(sum >> 32)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion3.rs:180:57
|
180 | || carry.map(|carry| pallas::Base::from(carry as u64)),
| ^^^^^^^^^^^^ help: try: `carry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs#L264
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/message_schedule/subregion2.rs:264:57
|
264 | || carry.map(|carry| pallas::Base::from(carry as u64)),
| ^^^^^^^^^^^^ help: try: `carry`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L56
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:56:34
|
56 | + DECOMPOSE_0_ROWS * (word_idx - 62) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 62)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L50
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:50:34
|
50 | + SUBREGION_3_WORD * (word_idx - 49) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 49)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs#L43
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/message_schedule/schedule_util.rs:43:47
|
43 | SUBREGION_0_ROWS + SUBREGION_1_WORD * (word_idx - 1) as usize
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(word_idx - 1)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L786
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:786:65
|
786 | || h_prime_carry.map(|value| pallas::Base::from(value as u64)),
| ^^^^^^^^^^^^ help: try: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_gadgets/src/sha256/table16/compression/compression_util.rs#L114
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_gadgets/src/sha256/table16/compression/compression_util.rs:114:13
|
114 | (idx as usize) * SUBREGION_MAIN_WORD
| ^^^^^^^^^^^^^^ help: try: `idx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L51
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:51:25
|
51 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs#L25
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/primitives/p128pow5t3.rs:25:25
|
25 | val.pow_vartime(&[5])
| ^^^^ help: change this to: `[5]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L513
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:513:77
|
513 | let r_0 = (p[0] + config.round_constants[round + 1][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L473
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:473:73
|
473 | let r_0 = (p[0] + config.round_constants[round][0]).pow(&config.alpha);
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/poseidon/pow5.rs#L447
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/poseidon/pow5.rs:447:62
|
447 | let r: Value<Vec<F>> = q.map(|q| q.map(|q| q.pow(&config.alpha))).collect();
| ^^^^^^^^^^^^^ help: change this to: `config.alpha`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
boolean to int conversion using if:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L493
warning: boolean to int conversion using if
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:493:53
|
493 | .fold(0, |acc, b| 2 * acc + if b { 1 } else { 0 })
| ^^^^^^^^^^^^^^^^^^^^^ help: replace with from: `usize::from(b)`
|
= note: `b as usize` or `b.into()` can also be valid options
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_to_int_with_if
= note: `-W clippy::bool-to-int-with-if` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L397
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:397:42
|
397 | .map(|k| k * (*H_SCALAR).pow(&[(NUM_WINDOWS - 1) as u64, 0, 0, 0]) - offset_acc);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(NUM_WINDOWS - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L392
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:392:37
|
392 | acc + (*TWO_SCALAR).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/mul_fixed.rs#L375
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/mul_fixed.rs:375:68
|
375 | let scalar = k.map(|k| (k + *TWO_SCALAR) * (*H_SCALAR).pow(&[w as u64, 0, 0, 0]));
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L220
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:220:45
|
220 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L217
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:217:42
|
217 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * w as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L200
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:200:53
|
200 | * C::Scalar::from(H as u64).pow(&[idx as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[idx as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L72
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:72:53
|
72 | * C::Scalar::from(H as u64).pow(&[(num_windows - 1) as u64, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(num_windows - 1) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L65
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:65:38
|
65 | acc + C::Scalar::from(2).pow(&[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0])
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[FIXED_BASE_WINDOW_SIZE as u64 * j as u64 + 1, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_gadgets/src/ecc/chip/constants.rs#L52
warning: the borrowed expression implements the required traits
--> halo2_gadgets/src/ecc/chip/constants.rs:52:57
|
52 | * C::Scalar::from(H as u64).pow(&[w as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[w as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L203
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:203:65
|
203 | root.draw(&Rectangle::new([top_left, bottom_right], &BLACK))?;
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/dev/graph/layout.rs#L187
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/dev/graph/layout.rs:187:13
|
187 | &BLACK,
| ^^^^^^ help: change this to: `BLACK`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L458
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:458:27
|
458 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L444
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:444:27
|
444 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L432
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:432:25
|
432 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L431
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:431:25
|
431 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L427
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:427:27
|
427 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L284
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:284:27
|
284 | self.state.update(&[KECCAK256_PREFIX_SCALAR]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_SCALAR]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L270
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:270:27
|
270 | self.state.update(&[KECCAK256_PREFIX_POINT]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_POINT]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L258
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:258:25
|
258 | state_hi.update(&[KECCAK256_PREFIX_CHALLENGE_HI]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_HI]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L257
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:257:25
|
257 | state_lo.update(&[KECCAK256_PREFIX_CHALLENGE_LO]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE_LO]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/transcript.rs#L253
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/transcript.rs:253:27
|
253 | self.state.update(&[KECCAK256_PREFIX_CHALLENGE]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[KECCAK256_PREFIX_CHALLENGE]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L104
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:104:49
|
104 | let root_pow = root.pow_vartime(&[offset as u64]);
| ^^^^^^^^^^^^^^^^ help: change this to: `[offset as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/kzg/commitment.rs#L100
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/kzg/commitment.rs:100:43
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L100
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:100:41
|
100 | let multiplier = (s.pow_vartime(&[n as u64]) - E::Scalar::ONE) * n_inv;
| ^^^^^^^^^^^ help: change this to: `[n as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/kzg/commitment.rs#L78
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/kzg/commitment.rs:78:40
|
78 | current_g *= s.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L620
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:620:30
|
620 | .pow_vartime(&[(rotation.0 as i64).unsigned_abs()]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(rotation.0 as i64).unsigned_abs()]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L616
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:616:52
|
616 | point *= &self.get_omega().pow_vartime(&[rotation.0 as u64]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[rotation.0 as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L550
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:550:45
|
550 | let mut c_power = c.pow_vartime(&[index as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[index as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/poly/domain.rs#L195
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/poly/domain.rs:195:34
|
195 | assert_eq!(values.len(), (self.extended_len() >> self.k) as usize);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(self.extended_len() >> self.k)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L103
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:103:53
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L103
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:103:51
|
103 | let step = extended_omega.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/poly/domain.rs#L102
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/poly/domain.rs:102:46
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/poly/domain.rs#L102
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/poly/domain.rs:102:44
|
102 | let orig = F::ZETA.pow_vartime(&[n as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[n as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L249
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:249:26
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L249
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:249:24
|
249 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/verifier.rs#L180
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/verifier.rs:180:26
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/verifier.rs#L180
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/verifier.rs:180:24
|
180 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
halo2_proofs/src/plonk/prover.rs#L554
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> halo2_proofs/src/plonk/prover.rs:554:22
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^ help: try: `params.n()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/prover.rs#L554
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/prover.rs:554:20
|
554 | let xn = x.pow(&[params.n() as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[params.n() as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/verifier.rs#L182
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/verifier.rs:182:46
|
182 | ... .pow_vartime(&[(chunk_index * chunk_len) as u64]));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(chunk_index * chunk_len) as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/prover.rs#L129
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/prover.rs:129:74
|
129 | let mut deltaomega = deltaomega * &omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L190
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:190:60
|
190 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L178
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:178:49
|
178 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L128
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:128:60
|
128 | let mut cur = C::Scalar::DELTA.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/permutation/keygen.rs#L116
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/permutation/keygen.rs:116:49
|
116 | let mut cur = omega.pow_vartime(&[start as u64]);
| ^^^^^^^^^^^^^^^ help: change this to: `[start as u64]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/plonk/lookup/prover.rs#L446
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/plonk/lookup/prover.rs:446:35
|
446 | permuted_table_coeffs[repeated_input_rows.pop().unwrap() as usize] = *coeff;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `repeated_input_rows.pop().unwrap()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/plonk/evaluation.rs#L694
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/plonk/evaluation.rs:694:57
|
694 | ... * omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L443
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:443:17
|
443 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L441
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:441:21
|
441 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L280
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:280:17
|
280 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L278
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:278:21
|
278 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L187
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:187:17
|
187 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L185
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:185:21
|
185 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/recursive.rs#L107
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/recursive.rs:107:43
|
107 | let mut w = o.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/recursive.rs#L87
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/recursive.rs:87:33
|
87 | let stages = get_stages(n as usize, vec![]);
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L264
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:264:17
|
264 | chunk = n as usize;
| ^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L262
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:262:21
|
262 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L232
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:232:39
|
232 | let new_omega = omega.pow_vartime(&[split_m as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[split_m as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L201
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:201:22
|
201 | let sub_n = n >> log_split as usize;
| ^^^^^^^^^^^^^^^^^^ help: try: `log_split`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L196
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:196:13
|
196 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L184
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:184:57
|
184 | let mut w_n = high_degree_omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L180
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:180:47
|
180 | let high_degree_omega = omega.pow_vartime(&[(1 << sparse_degree) as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[(1 << sparse_degree) as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L173
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:173:45
|
173 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L169
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:169:41
|
169 | let mut twiddle_lut = vec![F::ZERO; (low_degree_lut_len + high_degree_lut_len) as usize];
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(low_degree_lut_len + high_degree_lut_len)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L157
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:157:45
|
157 | let mut w_n = omega.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L128
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:128:21
|
128 | let omega_idx = sub_fft_offset as usize;
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `sub_fft_offset`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/fft/parallel.rs#L48
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/fft/parallel.rs:48:45
|
48 | let w_m: Scalar = omega.pow_vartime(&[u64::from(n / (2 * m)), 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[u64::from(n / (2 * m)), 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:33
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^ help: try: `k`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L42
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:42:20
|
42 | a.swap(rk as usize, k as usize);
| ^^^^^^^^^^^ help: try: `rk`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/parallel.rs#L24
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/parallel.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L47
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:47:33
|
47 | let mut twiddle_chunk = (n / 2) as usize;
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L36
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:36:32
|
36 | let twiddles: Vec<_> = (0..(n / 2) as usize)
| ^^^^^^^^^^^^^^^^ help: try: `(n / 2)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/fft/baseline.rs#L24
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/fft/baseline.rs:24:13
|
24 | let n = a.len() as usize;
| ^^^^^^^^^^^^^^^^ help: try: `a.len()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
|
iterating on a map's values:
halo2_proofs/src/circuit/floor_planner/v1.rs#L83
warning: iterating on a map's values
--> halo2_proofs/src/circuit/floor_planner/v1.rs:83:36
|
83 | let first_unassigned_row = column_allocations
| ____________________________________^
84 | | .iter()
85 | | .map(|(_, a)| a.unbounded_interval_start())
| |_______________________________________________________^ help: try: `column_allocations.values().map(|a| a.unbounded_interval_start())`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `-W clippy::iter-kv-map` implied by `-W clippy::all`
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
halo2_proofs/src/arithmetic.rs#L313
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> halo2_proofs/src/arithmetic.rs:313:21
|
313 | let mut chunk = (n as usize) / num_threads;
| ^^^^^^^^^^^^ help: try: `n`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L262
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:262:72
|
262 | out[0] = evaluate(poly, point) * point.pow_vartime(&[start as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `[start as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
the borrowed expression implements the required traits:
halo2_proofs/src/arithmetic.rs#L213
warning: the borrowed expression implements the required traits
--> halo2_proofs/src/arithmetic.rs:213:48
|
213 | let n_inv = C::Scalar::TWO_INV.pow_vartime(&[k as u64, 0, 0, 0]);
| ^^^^^^^^^^^^^^^^^^^^ help: change this to: `[k as u64, 0, 0, 0]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-W clippy::needless-borrow` implied by `-W clippy::all`
|
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|