Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support provide empty icon value #9408

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

splincode
Copy link
Member

@splincode splincode commented Oct 9, 2024

I want pass empty icons for screenshot testing

tuiIconsProvider({
  '@tui.heart': ''
})

Copy link

lumberjack-bot bot commented Oct 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Visit the preview URL for this PR (updated for commit 88396b3):

https://taiga-previews--pr9408-splincode-icon-resol-z8wxvf38.web.app

(expires Thu, 10 Oct 2024 08:35:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 9, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/styles.(hash).css
16.27KB (-132B -0.79%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
295KB +10%
demo/browser/vendor.(hash).js
247.33KB +10%
demo/browser/runtime.(hash).js
43.08KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -131B -0.02%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.13MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit d0577d6 into main Oct 10, 2024
30 checks passed
@splincode splincode deleted the splincode/icon-resolver branch October 10, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants