Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): disable zoom on Safari when focus textfield #6607

Closed
wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

Closes #6582

Copy link

lumberjack-bot bot commented Jan 30, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit ed7d3fe):

https://taiga-ui--pr6607-splincode-fix-ios-zo-cwtoz5sk.web.app

(expires Wed, 31 Jan 2024 10:56:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Jan 30, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
346.04KB (+62B +0.02%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.63KB +10%
demo/browser/runtime.(hash).js
34.18KB +10%
demo/browser/polyfills.(hash).js
11.24KB +10%
demo/browser/styles.(hash).css
1.06KB +10%

Total files change +62B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (+62B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@@ -288,6 +290,11 @@

.t-input {
.textfield-input();
.ios-only({
&:focus { // disable zoom
font-size: 16px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot do that, it would break the design. Large inputs are already 16px, small ones would look bad this way.

@waterplea
Copy link
Collaborator

How is that relevant to the mentioned issue?

@splincode splincode closed this Jan 30, 2024
@splincode splincode deleted the splincode/fix-ios-zoom branch January 30, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - DialogService
2 participants