Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): TuiAmount add new pipe #5735

Merged
merged 3 commits into from
Oct 27, 2023
Merged

feat(experimental): TuiAmount add new pipe #5735

merged 3 commits into from
Oct 27, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

@bundlemon
Copy link

bundlemon bot commented Oct 24, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
338.96KB (+275B +0.08%) +10%
demo/browser/runtime.(hash).js
38.71KB (+106B +0.27%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
201.03KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +381B +0.06%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.23MB (+4.83KB +0.21%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Visit the preview URL for this PR (updated for commit 7df0f51):

https://taiga-ui--pr5735-amount-pipe-i8rg59s9.web.app

(expires Sat, 28 Oct 2023 14:26:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 24, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will eventually need to support dynamic number formatting:
#2900
#2578

So how about this pipe to return Observable<string> so the API is ready for it?

Also, setting number format through just the token is pretty inconvenient. How about we add a new Observable token for number formatting and make a directive for it that extends BehaviorSubject with TUI_NUMBER_FORMAT as initial value and a partial TuiNumberFormatSettings as input? We can then gradually migrate everything to that new token and eventually get rid of static format settings.

@vladimirpotekhin vladimirpotekhin force-pushed the amount-pipe branch 2 times, most recently from 02d16b0 to 3daf9a2 Compare October 25, 2023 16:17
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #5735 (7df0f51) into main (58b6fe6) will increase coverage by 0.00%.
The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main    #5735   +/-   ##
=======================================
  Coverage   72.32%   72.33%           
=======================================
  Files        1451     1455    +4     
  Lines       15807    15827   +20     
  Branches     2224     2224           
=======================================
+ Hits        11433    11449   +16     
- Misses       4013     4017    +4     
  Partials      361      361           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.25% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 77.96% <80.00%> (+0.01%) ⬆️
kit 70.88% <ø> (ø)
summary 72.33% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
projects/core/constants/default-number-format.ts 100.00% <ø> (ø)
projects/core/directives/index.ts 100.00% <100.00%> (ø)
projects/core/directives/number-format/index.ts 100.00% <100.00%> (ø)
...e/directives/number-format/number-format.module.ts 100.00% <100.00%> (ø)
projects/core/tokens/index.ts 100.00% <100.00%> (ø)
projects/core/tokens/number-format-observable.ts 100.00% <100.00%> (ø)
...irectives/number-format/number-format.directive.ts 55.55% <55.55%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode merged commit 33588c3 into main Oct 27, 2023
34 of 35 checks passed
@splincode splincode deleted the amount-pipe branch October 27, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants