-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(experimental): TuiAmount
add new pipe
#5735
Conversation
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +381B +0.06% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 7df0f51): https://taiga-ui--pr5735-amount-pipe-i8rg59s9.web.app (expires Sat, 28 Oct 2023 14:26:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
6336819
to
1060332
Compare
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will eventually need to support dynamic number formatting:
#2900
#2578
So how about this pipe to return Observable<string>
so the API is ready for it?
Also, setting number format through just the token is pretty inconvenient. How about we add a new Observable
token for number formatting and make a directive for it that extends BehaviorSubject
with TUI_NUMBER_FORMAT
as initial value and a partial TuiNumberFormatSettings
as input? We can then gradually migrate everything to that new token and eventually get rid of static format settings.
02d16b0
to
3daf9a2
Compare
Codecov Report
@@ Coverage Diff @@
## main #5735 +/- ##
=======================================
Coverage 72.32% 72.33%
=======================================
Files 1451 1455 +4
Lines 15807 15827 +20
Branches 2224 2224
=======================================
+ Hits 11433 11449 +16
- Misses 4013 4017 +4
Partials 361 361
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3daf9a2
to
9398b88
Compare
a78bea4
to
7df0f51
Compare
PR Type
What kind of change does this PR introduce?
What is the current behaviour?
Closes #
What is the new behaviour?