Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): add InputMultiDate #5620

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat(kit): add InputMultiDate #5620

merged 1 commit into from
Oct 30, 2023

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #3624

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 12, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@splincode splincode force-pushed the splincode/feat/issues/3624 branch 2 times, most recently from 8d756cd to 003a039 Compare October 12, 2023 12:25
@bundlemon
Copy link

bundlemon bot commented Oct 12, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/main.(hash).js
340.3KB (+1.6KB +0.47%) +10%
demo/browser/runtime.(hash).js
38.66KB (+61B +0.15%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
201.03KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +1.66KB +0.27%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.24MB (+5.96KB +0.26%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

Visit the preview URL for this PR (updated for commit 43a4cf0):

https://taiga-ui--pr5620-splincode-feat-issue-sanzbauw.web.app

(expires Tue, 31 Oct 2023 05:45:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5620 (43a4cf0) into main (58b6fe6) will decrease coverage by 0.34%.
The diff coverage is 27.11%.

@@            Coverage Diff             @@
##             main    #5620      +/-   ##
==========================================
- Coverage   72.32%   71.99%   -0.34%     
==========================================
  Files        1451     1456       +5     
  Lines       15807    15919     +112     
  Branches     2224     2253      +29     
==========================================
+ Hits        11433    11461      +28     
- Misses       4013     4092      +79     
- Partials      361      366       +5     
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 60.80% <16.66%> (-0.45%) ⬇️
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.71% <ø> (ø)
core 77.95% <ø> (ø)
kit 70.11% <28.30%> (-0.78%) ⬇️
summary 71.99% <27.11%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...alendar-dialog/mobile-calendar-dialog.component.ts 50.00% <ø> (ø)
projects/kit/components/index.ts 100.00% <100.00%> (ø)
projects/kit/components/input-date-multi/index.ts 100.00% <100.00%> (ø)
...onents/input-date-multi/input-date-multi.module.ts 100.00% <100.00%> (ø)
...ts/kit/components/input-tag/input-tag.component.ts 77.70% <100.00%> (ø)
projects/kit/utils/date/index.ts 100.00% <100.00%> (ø)
projects/kit/utils/index.ts 100.00% <100.00%> (ø)
projects/kit/utils/date/update.ts 33.33% <33.33%> (ø)
...nents/mobile-calendar/mobile-calendar.component.ts 44.28% <16.66%> (-2.69%) ⬇️
...nts/input-date-multi/input-date-multi.component.ts 13.95% <13.95%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode force-pushed the splincode/feat/issues/3624 branch 2 times, most recently from ece60d6 to ebe9149 Compare October 12, 2023 16:12
Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's rename it to InputDateMultiple so that all the date related controls start with InputDate.
  2. I'm unable to type with keyboard.
  3. Android native picker has a button "Clear". If it's possible, it would be great to use use it to clear all selected dates.
  4. On demo let's fix width of the controls, it doesn't look that good when it changes as you select dates.

@vladimirpotekhin
Copy link
Member

Native input date

  1. There is no field for input from the keyboard, this is like select, so the dropdown should open by clicking on the entire area, and not just the calendar icon
  2. Cleaner in ios safari is broken
RPReplay_Final16974539802.mov

Also, there are no native "input-date multiple". Selected value in data-picker in this case does not match the input value, it seems like a bug. Maybe we just drop the "native" variant? what do you think @splincode @waterplea @nsbarsukov ?

@waterplea
Copy link
Collaborator

Native input date

  1. There is no field for input from the keyboard, this is like select, so the dropdown should open by clicking on the entire area, and not just the calendar icon
  2. Cleaner in ios safari is broken
RPReplay_Final16974539802.mov

Also, there are no native "input-date multiple". Selected value in data-picker in this case does not match the input value, it seems like a bug. Maybe we just drop the "native" variant? what do you think @splincode @waterplea @nsbarsukov ?

Let's drop the native input for the first iteration and explore it in a separate issue, because there are also a11y concerns.

@splincode splincode force-pushed the splincode/feat/issues/3624 branch 9 times, most recently from b0c83c6 to 36a4454 Compare October 22, 2023 16:24
@splincode
Copy link
Member Author

@waterplea @vladimirpotekhin hello, please review me

@splincode splincode force-pushed the splincode/feat/issues/3624 branch 2 times, most recently from ea3f1a5 to 4a7fbc5 Compare October 23, 2023 13:56
@splincode splincode force-pushed the splincode/feat/issues/3624 branch 3 times, most recently from 3d59d4b to 6be6422 Compare October 23, 2023 14:15
@splincode splincode force-pushed the splincode/feat/issues/3624 branch 2 times, most recently from 24d349d to 2ef197c Compare October 25, 2023 14:50
@splincode splincode force-pushed the splincode/feat/issues/3624 branch 2 times, most recently from c342b78 to 99e0be6 Compare October 25, 2023 20:36
@splincode splincode merged commit 180930e into main Oct 30, 2023
39 of 40 checks passed
@splincode splincode deleted the splincode/feat/issues/3624 branch October 30, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🚀 - Multiple dates input
3 participants