-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kit): add InputMultiDate
#5620
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
8d756cd
to
003a039
Compare
BundleMonFiles updated (2)
Unchanged files (4)
Total files change +1.66KB +0.27% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
Visit the preview URL for this PR (updated for commit 43a4cf0): https://taiga-ui--pr5620-splincode-feat-issue-sanzbauw.web.app (expires Tue, 31 Oct 2023 05:45:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4b5ece1e114386f6a105425ef799091475b249eb |
Codecov Report
@@ Coverage Diff @@
## main #5620 +/- ##
==========================================
- Coverage 72.32% 71.99% -0.34%
==========================================
Files 1451 1456 +5
Lines 15807 15919 +112
Branches 2224 2253 +29
==========================================
+ Hits 11433 11461 +28
- Misses 4013 4092 +79
- Partials 361 366 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ece60d6
to
ebe9149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's rename it to
InputDateMultiple
so that all the date related controls start withInputDate
. - I'm unable to type with keyboard.
- Android native picker has a button "Clear". If it's possible, it would be great to use use it to clear all selected dates.
- On demo let's fix width of the controls, it doesn't look that good when it changes as you select dates.
projects/kit/components/input-date/multi-date/input-multi-date.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-multi-date.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-multi-date.directive.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-multi-date.component.ts
Outdated
Show resolved
Hide resolved
RPReplay_Final16974539802.movAlso, there are no native "input-date multiple". Selected value in data-picker in this case does not match the input value, it seems like a bug. Maybe we just drop the "native" variant? what do you think @splincode @waterplea @nsbarsukov ? |
Let's drop the native input for the first iteration and explore it in a separate issue, because there are also a11y concerns. |
b0c83c6
to
36a4454
Compare
@waterplea @vladimirpotekhin hello, please review me |
projects/kit/components/input-date/multi-date/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.component.ts
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.module.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-date-multi.directive.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-date-multi.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date/multi-date/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
ea3f1a5
to
4a7fbc5
Compare
3d59d4b
to
6be6422
Compare
6be6422
to
66028eb
Compare
projects/kit/components/input-date/multi-date/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.component.ts
Show resolved
Hide resolved
projects/demo/src/modules/components/input-date-multi/input-date-multi.template.html
Outdated
Show resolved
Hide resolved
66028eb
to
913560e
Compare
24d349d
to
2ef197c
Compare
projects/kit/components/input-date-multi/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.directive.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.module.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.template.html
Outdated
Show resolved
Hide resolved
c342b78
to
99e0be6
Compare
projects/demo/src/modules/components/input-date-multi/input-date-multi.module.ts
Show resolved
Hide resolved
99e0be6
to
ef97028
Compare
projects/kit/components/input-date-multi/input-date-multi.template.html
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.module.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.module.ts
Outdated
Show resolved
Hide resolved
projects/kit/components/input-date-multi/input-date-multi.component.ts
Outdated
Show resolved
Hide resolved
ef97028
to
43a4cf0
Compare
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3624
What is the new behavior?