Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk): add array of icons, used in taiga components #5005

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 31, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Visit the preview URL for this PR (updated for commit 8993f12):

https://taiga-ui--pr5005-script-used-icons-80zfka1d.web.app

(expires Tue, 01 Aug 2023 15:08:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon
Copy link

bundlemon bot commented Jul 31, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
325.23KB (+255B +0.08%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.62KB +10%
demo/browser/runtime.(hash).js
36.09KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +265B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.07MB (+265B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.29% ⚠️

Comparison is base (bd8a319) 72.23% compared to head (3510a9a) 70.95%.
Report is 5 commits behind head on main.

❗ Current head 3510a9a differs from pull request most recent head 8993f12. Consider uploading reports for the commit 8993f12 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5005      +/-   ##
==========================================
- Coverage   72.23%   70.95%   -1.29%     
==========================================
  Files        1416     1117     -299     
  Lines       15392    12127    -3265     
  Branches     2159     1676     -483     
==========================================
- Hits        11119     8605    -2514     
+ Misses       3924     3261     -663     
+ Partials      349      261      -88     
Flag Coverage Δ
addon-charts 70.82% <ø> (ø)
addon-doc 59.50% <ø> (ø)
addon-mobile 61.21% <ø> (ø)
addon-table 60.35% <ø> (ø)
addon-tablebars 92.72% <ø> (ø)
cdk 79.62% <100.00%> (+0.01%) ⬆️
core ?
kit 71.22% <ø> (ø)
summary 70.95% <100.00%> (-1.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
projects/cdk/constants/index.ts 100.00% <100.00%> (ø)
projects/cdk/constants/used-icons.ts 100.00% <100.00%> (ø)

... and 300 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved automated PR for Tinkoff[bot]

@splincode splincode merged commit c989f60 into main Jul 31, 2023
42 checks passed
@splincode splincode deleted the script-used-icons branch July 31, 2023 16:04
@well-done-bot
Copy link

well-done-bot bot commented Jul 31, 2023

'Well done'

@tinkoff-bot tinkoff-bot mentioned this pull request Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants