Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): switch to power of 2 for file size display #4997

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Conversation

waterplea
Copy link
Collaborator

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behavior?

Closes #

What is the new behavior?

@lumberjack-bot
Copy link

lumberjack-bot bot commented Jul 27, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Visit the preview URL for this PR (updated for commit 0c51f7b):

https://taiga-ui--pr4997-mebibyte-2-lu0k36yr.web.app

(expires Sat, 29 Jul 2023 08:22:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2.x@5e1efcc). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #4997   +/-   ##
=======================================
  Coverage        ?   58.40%           
=======================================
  Files           ?     1061           
  Lines           ?    11707           
  Branches        ?     2252           
=======================================
  Hits            ?     6838           
  Misses          ?     4382           
  Partials        ?      487           
Flag Coverage Δ
addon-charts 75.29% <0.00%> (?)
addon-doc 27.70% <0.00%> (?)
addon-editor 27.05% <0.00%> (?)
addon-mobile ∅ <0.00%> (?)
addon-table 79.59% <0.00%> (?)
addon-tablebars ∅ <0.00%> (?)
cdk 67.68% <0.00%> (?)
core 68.02% <0.00%> (?)
kit 62.77% <0.00%> (?)
summary 58.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode
Copy link
Member

@waterplea please update too
image

@splincode splincode merged commit 347450b into v2.x Jul 28, 2023
18 of 19 checks passed
@splincode splincode deleted the mebibyte-2 branch July 28, 2023 09:25
@well-done-bot
Copy link

well-done-bot bot commented Jul 28, 2023

'Well done'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants