chore: explicit run e2e type check (#9668)

taiga-family · Nov 5, 2024 · da3ae1c · da3ae1c
1 parent 6e26096
commit da3ae1c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
@@ -22,6 +22,7 @@ jobs:
         continue-on-error: true
       - uses: taiga-family/ci/actions/setup/[email protected]
 
+      - run: npx nx type-check demo-playwright
       - name: Building demo-app of git-branch without cache
         run: npx nx build demo # Don't use prerender please, because it's flaky for e2e
 

diff --git a/projects/demo-playwright/project.json b/projects/demo-playwright/project.json
@@ -14,19 +14,15 @@
         "e2e": {
             "executor": "nx:run-commands",
             "options": {
-                "command": "playwright test --config {projectRoot}/playwright.config.ts"
-            },
-            "dependsOn": [
-                {
-                    "target": "type-check",
-                    "params": "ignore"
-                }
-            ]
+                "command": "playwright test --config {projectRoot}/playwright.config.ts",
+                "forwardAllArgs": true
+            }
         },
         "e2e-ui": {
             "executor": "nx:run-commands",
             "options": {
-                "command": "nx e2e {projectName} -- --ui --debug --update-snapshots"
+                "command": "playwright test --config {projectRoot}/playwright.config.ts --ui --debug --update-snapshots",
+                "forwardAllArgs": true
             }
         }
     }