Update e2e tests for MV3 #3766
Draft
Update e2e tests for MV3 #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the new extension service worker available through the previously used background page fixture.
This provides direct access to the same commands executed in the github actions workflow
hyphenized
force-pushed
the
e2e-mv3
branch
2 times, most recently
from
1753252 to
5b932d7
Compare
Allows intercepting requests from the extension service worker(s) in playwright
|
Oof incidentally looks like our upload-action usage is about to be killed on Jan 30 🙃 Looks like we're still seeing some light failures in the tests, might be timing-related though and seems like a better outcome than previously. I'd be down to merge this & keep rolling once the lint issues are resolved. |
>.<
Yeah I agree.. let me see if I can get some of these resolved before merging this. For some reason my linter went on PTO 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tests still need to be updated but this seems to be working for now.
Latest build: extension-builds-3766 (as of Fri, 17 Jan 2025 06:11:00 GMT).