BSC improvements #2729
Merged
BSC improvements #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 6, 2022 10:51
kkosiorowska
requested review from
jagodarybacka,
greg-nagy,
0xDaedalus and
hyphenized
0xDaedalus
reviewed
Dec 8, 2022
background/lib/gas.ts
Outdated
| @@ -112,6 +113,39 @@ const getArbitrumPrices = async ( | |||
| } | |||
| } | |||
|
|
|||
| const getLegacyGasPrices = async ( | |||
| network: EVMNetwork, | |||
| baseFeePerGas: bigint, | |||
There was a problem hiding this comment.
lets call this parameter gasPrice
| @@ -86,18 +89,22 @@ export default function SignTransactionDetailPanel({ | |||
| setNetworkSettingsModalOpen(false) | |||
| } | |||
|
|
|||
| const hight = `${ | |||
There was a problem hiding this comment.
I think we might benefit from pulling the logic in here into its own function
0xDaedalus
suggested changes
Dec 8, 2022
Good catch! Now it should be fine.
|
0xDaedalus
approved these changes
Dec 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2569
This PR adds support for Binance Smart Chain by including some improvements.
Changes in PR
UI Changes in PR
To Test:
Set
SUPPORT_BINANCE_SMART_CHAINtotrue.Required points
Additional requirements to close #2569
Latest build: extension-builds-2729 (as of Fri, 09 Dec 2022 10:28:11 GMT).