🪄 [QA] Update stage environments #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closes #564 <img width="696" alt="Screenshot 2023-10-27 at 09 24 01" src="https://github.com/tahowallet/dapp/assets/23117945/ba6f52f7-ebbd-4250-a8da-273ffb95aa64">
✅ Deploy Preview for taho-development ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closes #569 ### What - Don't send an event when the realm modal is closed. - Use realm name for events > “Realm open” seems to be sending a null realm id most of the time. How might we normalize realm open's id and realm stake/unstake's? Right now one is address and the other is I assume the map node id. Normalizing to realm address might be most straightforward. At first blush I'd want to do name, but names can change in the long run—doesn't really matter for the beta though, so if this is easy let's do that. Why might we be overcounting stake completed events? Right now these seem to be ~30% higher than the actual staked count, even if we subtract the few unstakes. Is it possible we're not overcounting/that we're counting a stake as complete from a PostHog perspective when it didn't actually go through? We are currently tracking every stake transaction. When a user joins a realm, can stake more times for this realm. Therefore, the number of stake transactions is greater than the population.
Resolves #570 On mobile breakpoint we should only render `MobileScreen` instead of all the components
andreachapman
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request that upon merging will update stage environments with recent
mainchanges.The environments that will be updated:
Read more: Deployment to Production Flow